src/inspector/v8-stack-trace-impl.h - Issue 2868423004: Revert of [inspector] use creation stack trace as parent for async call chains

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/inspector/v8-stack-trace-impl.h

Issue 2868423004: Revert of [inspector] use creation stack trace as parent for async call chains (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/inspector/v8-stack-trace-impl.h

diff --git a/src/inspector/v8-stack-trace-impl.h b/src/inspector/v8-stack-trace-impl.h

index 1fc1cdc619e91835d3f493f5df53a2591a2fbfb7..302f6fbbb92dc3e7a4ac94442b869d1142b0ce4f 100644

--- a/src/inspector/v8-stack-trace-impl.h

+++ b/src/inspector/v8-stack-trace-impl.h

@@ -102,12 +102,6 @@

std::weak_ptr<AsyncStackTrace> creation() const;

bool isEmpty() const;

- void setDescription(const String16& description) {

- // TODO(kozyatinskiy): implement it without hack.

- DCHECK(!m_description.length() || m_description == description);

- m_description = description;

- }

private:

AsyncStackTrace(int contextGroupId, const String16& description,

std::vector<std::shared_ptr<StackFrame>> frames,

« no previous file with comments | « src/inspector/v8-debugger.cc ('k') | src/inspector/v8-stack-trace-impl.cc » ('j') | no next file with comments »