Updated new translate UI bubble text.

Updated new translate UI bubble text.

When translate was applied to pages with too little text, the bubble used to
display an empty "source language" string (and cause a crash in debug mode),
but now displays the string "Unknown" instead.

BUG=707209
Review-Url: https://codereview.chromium.org/2867993002
Cr-Commit-Position: refs/heads/master@{#472654}
Committed: https://chromium.googlesource.com/chromium/src/+/fc76272c18a0536e5684742d211ab00bf60b0dc1

[martis, 2017-05-11 06:34:39]

Description was changed from

==========
Updated new translate UI bubble text.

When translate was applied to pages with too little text, the bubble used to
display an empty "source language" string (and cause a crash in debug mode),
but now displays the string "Unknown" instead.

BUG=707209
==========

to

==========
Updated new translate UI bubble text.

When translate was applied to pages with too little text, the bubble used to
display an empty "source language" string (and cause a crash in debug mode),
but now displays the string "Unknown" instead.

BUG=707209
==========

[martis, 2017-05-11 06:34:39]

martis@chromium.org changed reviewers:
+ groby@chromium.org, rockot@chromium.org

[martis, 2017-05-11 06:36:22]

+Rachel for review
+Ken for generated_resources OWNERS

Thanks

[martis, 2017-05-11 07:06:23]

Yana,

As a side-effect of strings being translated "atomically", this UI text will
have inconsistent capitalisation until it has been manually translated
(apparently order ~weeks).

e.g. with an Italian UI, you'll see the message:
Vuoi che Google traduca la pagina da Sconosciuto in italiano?
where the work for "Unknown" is capitalized, and the word for "Italian" is not.

Is this okay, or should I look into manually expediting the translation process?

[martis, 2017-05-11 07:30:49]

On 2017/05/11 07:06:23, martis wrote:
> Yana,
> 
> As a side-effect of strings being translated "atomically", this UI text will
> have inconsistent capitalisation until it has been manually translated
> (apparently order ~weeks).
> 
> e.g. with an Italian UI, you'll see the message:
> Vuoi che Google traduca la pagina da Sconosciuto in italiano?
> where the work for "Unknown" is capitalized, and the word for "Italian" is
not.
> 
> Is this okay, or should I look into manually expediting the translation
process?

For more context on this:

It appears that Chrome reuses the existing translation of identical strings
until a manual translation is provided (this is what I meant by "atomic"
translations). Because there is already an instance of the string "Unknown" in
the UI resources, it's existing translations will be used until the newly-added
string has been translated. The existing translations are all capitalized,
whereas the convention in some languages (e.g. Italian) is not to capitalize
language names; I've left a specific instruction about this for the new string.

So, until the new string has been translated, the UI text will have inconsistent
capitalization in these languages.

[groby-ooo-7-16, 2017-05-11 14:37:49]

On 2017/05/11 07:30:49, martis wrote:
> On 2017/05/11 07:06:23, martis wrote:
> > Yana,
> > 
> > As a side-effect of strings being translated "atomically", this UI text will
> > have inconsistent capitalisation until it has been manually translated
> > (apparently order ~weeks).
> > 
> > e.g. with an Italian UI, you'll see the message:
> > Vuoi che Google traduca la pagina da Sconosciuto in italiano?
> > where the work for "Unknown" is capitalized, and the word for "Italian" is
> not.
> > 
> > Is this okay, or should I look into manually expediting the translation
> process?
> 
> For more context on this:
> 
> It appears that Chrome reuses the existing translation of identical strings
> until a manual translation is provided (this is what I meant by "atomic"
> translations)

It does... unless you add a meaning= attribute to your string. See
go/grit-msg-format (internal, sorry) for details

> . Because there is already an instance of the string "Unknown" in
> the UI resources, it's existing translations will be used until the
newly-added
> string has been translated. The existing translations are all capitalized,
> whereas the convention in some languages (e.g. Italian) is not to capitalize
> language names; I've left a specific instruction about this for the new
string.

The translators will not even see the new string if it's a duplicate. Unless you
add meaning ;)

> 
> So, until the new string has been translated, the UI text will have
inconsistent
> capitalization in these languages.

[Ken Rockot(use gerrit already), 2017-05-11 15:39:56]

No need for a chrome/app owner, as the OWNERS file has a wildcard exception for
generated_resources.grd.

Still, RS LGTM since I'm here.

[martis, 2017-05-11 23:27:19]

On 2017/05/11 14:37:49, groby wrote:
> On 2017/05/11 07:30:49, martis wrote:
> > On 2017/05/11 07:06:23, martis wrote:
> > > Yana,
> > > 
> > > As a side-effect of strings being translated "atomically", this UI text
will
> > > have inconsistent capitalisation until it has been manually translated
> > > (apparently order ~weeks).
> > > 
> > > e.g. with an Italian UI, you'll see the message:
> > > Vuoi che Google traduca la pagina da Sconosciuto in italiano?
> > > where the work for "Unknown" is capitalized, and the word for "Italian" is
> > not.
> > > 
> > > Is this okay, or should I look into manually expediting the translation
> > process?
> > 
> > For more context on this:
> > 
> > It appears that Chrome reuses the existing translation of identical strings
> > until a manual translation is provided (this is what I meant by "atomic"
> > translations)
> 
> It does... unless you add a meaning= attribute to your string. See
> go/grit-msg-format (internal, sorry) for details
> 
> > . Because there is already an instance of the string "Unknown" in
> > the UI resources, it's existing translations will be used until the
> newly-added
> > string has been translated. The existing translations are all capitalized,
> > whereas the convention in some languages (e.g. Italian) is not to capitalize
> > language names; I've left a specific instruction about this for the new
> string.
> 
> The translators will not even see the new string if it's a duplicate. Unless
you
> add meaning ;)
> 
> > 
> > So, until the new string has been translated, the UI text will have
> inconsistent
> > capitalization in these languages.

Thanks for the context! Meaning attribute added.

[martis, 2017-05-15 00:31:10]

On 2017/05/11 23:27:19, martis wrote:
> On 2017/05/11 14:37:49, groby wrote:
> > On 2017/05/11 07:30:49, martis wrote:
> > > On 2017/05/11 07:06:23, martis wrote:
> > > > Yana,
> > > > 
> > > > As a side-effect of strings being translated "atomically", this UI text
> will
> > > > have inconsistent capitalisation until it has been manually translated
> > > > (apparently order ~weeks).
> > > > 
> > > > e.g. with an Italian UI, you'll see the message:
> > > > Vuoi che Google traduca la pagina da Sconosciuto in italiano?
> > > > where the work for "Unknown" is capitalized, and the word for "Italian"
is
> > > not.
> > > > 
> > > > Is this okay, or should I look into manually expediting the translation
> > > process?
> > > 
> > > For more context on this:
> > > 
> > > It appears that Chrome reuses the existing translation of identical
strings
> > > until a manual translation is provided (this is what I meant by "atomic"
> > > translations)
> > 
> > It does... unless you add a meaning= attribute to your string. See
> > go/grit-msg-format (internal, sorry) for details
> > 
> > > . Because there is already an instance of the string "Unknown" in
> > > the UI resources, it's existing translations will be used until the
> > newly-added
> > > string has been translated. The existing translations are all capitalized,
> > > whereas the convention in some languages (e.g. Italian) is not to
capitalize
> > > language names; I've left a specific instruction about this for the new
> > string.
> > 
> > The translators will not even see the new string if it's a duplicate. Unless
> you
> > add meaning ;)
> > 
> > > 
> > > So, until the new string has been translated, the UI text will have
> > inconsistent
> > > capitalization in these languages.
> 
> Thanks for the context! Meaning attribute added.

Did you have any other concerns preventing LGTM?

[groby-ooo-7-16, 2017-05-15 20:21:45]

lgtm

[martis, 2017-05-18 01:17:44]

The CQ bit was checked by martis@chromium.org

[martis, 2017-05-18 01:17:44]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2867993002/#ps60001
(title: "Disambiguated UI string with a meaning attribute.")

[commit-bot: I haz the power, 2017-05-18 01:19:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 04:01:36]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495070264173990,
"parent_rev": "1e395f467754ae5411356108f0cccb8ea565207d", "commit_rev":
"fc76272c18a0536e5684742d211ab00bf60b0dc1"}

[commit-bot: I haz the power, 2017-05-18 04:01:43]

Description was changed from

==========
Updated new translate UI bubble text.

When translate was applied to pages with too little text, the bubble used to
display an empty "source language" string (and cause a crash in debug mode),
but now displays the string "Unknown" instead.

BUG=707209
==========

to

==========
Updated new translate UI bubble text.

When translate was applied to pages with too little text, the bubble used to
display an empty "source language" string (and cause a crash in debug mode),
but now displays the string "Unknown" instead.

BUG=707209

Review-Url: https://codereview.chromium.org/2867993002
Cr-Commit-Position: refs/heads/master@{#472654}
Committed:
https://chromium.googlesource.com/chromium/src/+/fc76272c18a0536e5684742d211a...
==========

[commit-bot: I haz the power, 2017-05-18 04:01:44]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/fc76272c18a0536e5684742d211a...