Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: chrome/browser/ui/views/translate/translate_bubble_view.cc

Issue 2867993002: Updated new translate UI bubble text. (Closed)
Patch Set: Disambiguated UI string with a meaning attribute. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/translate/translate_bubble_view.cc
diff --git a/chrome/browser/ui/views/translate/translate_bubble_view.cc b/chrome/browser/ui/views/translate/translate_bubble_view.cc
index 9fc5572b179be3380e4e47b6357339fd3d05585c..922a840c8a22053e214486d167b6ca3af0cc044e 100644
--- a/chrome/browser/ui/views/translate/translate_bubble_view.cc
+++ b/chrome/browser/ui/views/translate/translate_bubble_view.cc
@@ -524,8 +524,13 @@ void TranslateBubbleView::UpdateChildVisibilities() {
views::View* TranslateBubbleView::CreateViewBeforeTranslate() {
const int kQuestionWidth = 200;
+
base::string16 original_language_name =
model_->GetLanguageNameAt(model_->GetOriginalLanguageIndex());
+ if (original_language_name.empty()) {
+ original_language_name =
+ l10n_util::GetStringUTF16(IDS_TRANSLATE_BUBBLE_UNKNOWN_LANGUAGE);
+ }
views::View* view = new views::View();
views::GridLayout* layout = new views::GridLayout(view);
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698