webkitpy: Make webkit_base() protected.

third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py
index 8cc1462190b034d13f92cde8cfc02a9e8c720170..45746d9aabaef9a1c2d1f7dda4f096236a6ed36b 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py
@@ -465,9 +465,6 @@ class TestPort(Port):
     def perf_tests_dir(self):
         return PERF_TEST_DIR

[qyearsley, 2017/05/09 21:46:28]

Later, we may want to change the layout_tests_dir and perf_tests_dir used by
TestPort -- right now they're hard-coded to special non-standard locations
'/test.checkout/LayoutTests' and '/test.checkout/PerformanceTests'.

After this change, this is now inconsistent with webkit_base() below, which will
return something more like "/mock_checkout/third_party/WebKit" (I think).

[tkent, 2017/05/10 23:42:21]

Port.layout_tests_dir can be different from webkit_base()/LayoutTests because of
layout_tests_directory option. So we don't need to change
TestPort.layout_tests_dir, IMO.

We should remove Port.perf_tests_dir() as the TODO(qyearsley) in base.py says.

 
-    def webkit_base(self):
-        return '/test.checkout'

[qyearsley, 2017/05/09 21:46:28]

I would have expected that changing this might require updating tests. I guess
that's not the case?

[tkent, 2017/05/10 23:42:21]

Port.webkit_base() was used only for PerTestsRunner._webkit_base_dir_len. 
That's a dead code.

-
     def skipped_layout_tests(self, _):
         return set(['failures/expected/skip_text.html',
                     'failures/unexpected/skip_pass.html',