third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder_unittest.py - Issue 2867713007: webkitpy: Make webkit_base() protected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder_unittest.py

Issue 2867713007: webkitpy: Make webkit_base() protected. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py ('K') | « third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py » ('j') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder_unittest.py

index 278b7ce82203b700cacfdb22fa2079d9c9072b35..3ca20c8545e817f58b535167cc2ca5e5575b97c0 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder_unittest.py

@@ -25,7 +25,7 @@ class TestWebKitFinder(unittest.TestCase):

def test_webkit_base(self):

finder = WebKitFinder(MockFileSystem())

- self.assertEqual(finder.webkit_base(), '/mock-checkout/third_party/WebKit')

+ self.assertEqual(finder._webkit_base(), '/mock-checkout/third_party/WebKit')

qyearsley 2017/05/09 21:46:28 I would expect a "protected-access" pylint warning

tkent 2017/05/10 23:42:21 Ah, right. pylint complains this. Neither test-we

def test_chromium_base(self):

finder = WebKitFinder(MockFileSystem())