webkitpy: Make webkit_base() protected.

third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py

 # Copyright (C) 2010 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 445 matching lines @@
         if not actual_contents or not expected_contents:
             return (True, None)
         if diffed:
             return ('< %s\n---\n> %s\n' % (expected_contents, actual_contents), None)
         return (None, None)
 
     def layout_tests_dir(self):
         return LAYOUT_TEST_DIR
 
     def perf_tests_dir(self):
         return PERF_TEST_DIR

[qyearsley, 2017/05/09 21:46:28]

Later, we may want to change the layout_tests_dir and perf_tests_dir used by
TestPort -- right now they're hard-coded to special non-standard locations
'/test.checkout/LayoutTests' and '/test.checkout/PerformanceTests'.

After this change, this is now inconsistent with webkit_base() below, which will
return something more like "/mock_checkout/third_party/WebKit" (I think).

[tkent, 2017/05/10 23:42:21]

Port.layout_tests_dir can be different from webkit_base()/LayoutTests because of
layout_tests_directory option. So we don't need to change
TestPort.layout_tests_dir, IMO.

We should remove Port.perf_tests_dir() as the TODO(qyearsley) in base.py says.

 
-    def webkit_base(self):
-        return '/test.checkout'

[qyearsley, 2017/05/09 21:46:28]

I would have expected that changing this might require updating tests. I guess
that's not the case?

[tkent, 2017/05/10 23:42:21]

Port.webkit_base() was used only for PerTestsRunner._webkit_base_dir_len. 
That's a dead code.

-
     def skipped_layout_tests(self, _):
         return set(['failures/expected/skip_text.html',
                     'failures/unexpected/skip_pass.html',
                     'virtual/skipped/failures/expected'])
 
     def name(self):
         return self._name
 
     def operating_system(self):
         return self._operating_system
@@ skipping 151 matching lines @@
         else:
             image = test.actual_image
         return DriverOutput(actual_text, image, test.actual_checksum, audio,
                             crash=(crash or web_process_crash), crashed_process_name=crashed_process_name,
                             crashed_pid=crashed_pid, crash_log=crash_log,
                             test_time=time.time() - start_time, timeout=test.timeout, error=test.error, pid=self.pid,
                             leak=test.leak)
 
     def stop(self):
         self.started = False