third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py - Issue 2867713007: webkitpy: Make webkit_base() protected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py

Issue 2867713007: webkitpy: Make webkit_base() protected. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py ('K') | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py b/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py

index 2c428b591c371cb6acb9f55564420536f0ca450e..c79a9fcbc1b1cfcd827b6c94c155caf474ee60b2 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py

@@ -63,7 +63,6 @@ class PerfTestsRunner(object):

else:

self._host = Host()

self._port = self._host.port_factory.get(self._options.platform, self._options)

- self._webkit_base_dir_len = len(self._port.webkit_base())

tkent 2017/05/09 01:19:50 _webkit_base_dir_len isn't used.

qyearsley 2017/05/09 21:46:28 Excellent :-)

self._base_path = self._port.perf_tests_dir()

self._timestamp = time.time()

self._utc_timestamp = datetime.datetime.utcnow()