Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2866773002: Stream Request takes a Handle* instead of a std::unique_ptr<Handle> (Closed)

Created:
3 years, 7 months ago by Ryan Hamilton
Modified:
3 years, 7 months ago
Reviewers:
xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Stream Request takes a Handle* instead of a std::unique_ptr<Handle> BUG=716563 Review-Url: https://codereview.chromium.org/2866773002 Cr-Commit-Position: refs/heads/master@{#469854} Committed: https://chromium.googlesource.com/chromium/src/+/9ddcdeddcd8b04d0a0654d90b9a4cb9aa20faae1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M net/quic/chromium/quic_chromium_client_session.h View 2 chunks +3 lines, -2 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_session.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
xunjieli
LGTM Could you attach the crbug/716563?
3 years, 7 months ago (2017-05-05 19:53:41 UTC) #2
Ryan Hamilton
On 2017/05/05 19:53:41, xunjieli wrote: > LGTM Could you attach the crbug/716563? Done. Thanks!
3 years, 7 months ago (2017-05-05 19:57:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2866773002/1
3 years, 7 months ago (2017-05-05 19:57:38 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/287050)
3 years, 7 months ago (2017-05-05 23:08:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2866773002/1
3 years, 7 months ago (2017-05-05 23:18:43 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-06 18:56:21 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9ddcdeddcd8b04d0a0654d90b9a4...

Powered by Google App Engine
This is Rietveld 408576698