Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Unified Diff: net/quic/chromium/quic_chromium_client_session.h

Issue 2866773002: Stream Request takes a Handle* instead of a std::unique_ptr<Handle> (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/chromium/quic_chromium_client_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/chromium/quic_chromium_client_session.h
diff --git a/net/quic/chromium/quic_chromium_client_session.h b/net/quic/chromium/quic_chromium_client_session.h
index 4e8ff6b2f1eed72acecd060d28b480dabcd8488c..182aabff9e4ee9581c326bb740e3f89ce3978417 100644
--- a/net/quic/chromium/quic_chromium_client_session.h
+++ b/net/quic/chromium/quic_chromium_client_session.h
@@ -206,7 +206,8 @@ class NET_EXPORT_PRIVATE QuicChromiumClientSession
STATE_REQUEST_STREAM_COMPLETE,
};
- StreamRequest(std::unique_ptr<QuicChromiumClientSession::Handle> session,
+ // |session| must outlive this request.
+ StreamRequest(QuicChromiumClientSession::Handle* session,
bool requires_confirmation);
void OnIOComplete(int rv);
@@ -227,7 +228,7 @@ class NET_EXPORT_PRIVATE QuicChromiumClientSession
// if |session_| is destroyed while the stream request is still pending.
void OnRequestCompleteFailure(int rv);
- std::unique_ptr<QuicChromiumClientSession::Handle> session_;
+ QuicChromiumClientSession::Handle* session_;
const bool requires_confirmation_;
CompletionCallback callback_;
QuicChromiumClientStream* stream_;
« no previous file with comments | « no previous file | net/quic/chromium/quic_chromium_client_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698