Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Unified Diff: net/quic/chromium/quic_chromium_client_session.cc

Issue 2866773002: Stream Request takes a Handle* instead of a std::unique_ptr<Handle> (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/chromium/quic_chromium_client_session.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/chromium/quic_chromium_client_session.cc
diff --git a/net/quic/chromium/quic_chromium_client_session.cc b/net/quic/chromium/quic_chromium_client_session.cc
index 4255d8aae3c4e677d2393eaa49ed723f5a053698..85ae9bc94efa3142681119e561b3f0b34ffdb22c 100644
--- a/net/quic/chromium/quic_chromium_client_session.cc
+++ b/net/quic/chromium/quic_chromium_client_session.cc
@@ -296,7 +296,7 @@ int QuicChromiumClientSession::Handle::RequestStream(
// base::MakeUnique does not work because the StreamRequest constructor
// is private.
stream_request_ = std::unique_ptr<StreamRequest>(
- new StreamRequest(session_->CreateHandle(), requires_confirmation));
+ new StreamRequest(this, requires_confirmation));
return stream_request_->StartRequest(callback);
}
@@ -346,7 +346,7 @@ int QuicChromiumClientSession::Handle::GetPeerAddress(
}
QuicChromiumClientSession::StreamRequest::StreamRequest(
- std::unique_ptr<QuicChromiumClientSession::Handle> session,
+ QuicChromiumClientSession::Handle* session,
bool requires_confirmation)
: session_(std::move(session)),
requires_confirmation_(requires_confirmation),
« no previous file with comments | « net/quic/chromium/quic_chromium_client_session.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698