Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2866503002: Revert removal of AudioBufferCallback (Closed)

Created:
3 years, 7 months ago by Raymond Toy
Modified:
3 years, 7 months ago
Reviewers:
Mike West, foolip, hongchan
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews, haraken, hongchan, Raymond Toy
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert removal of AudioBufferCallback Manually revert https://codereview.chromium.org/2820113006/ That CL causes decodeAudioData callbacks not to be called sometimes. Apparently, it might be a GC problem where the callbacks are collected before decodeAudioData calls them. BUG=717723, 707338 TEST=manually run box2d test and verify convolver.buffer exists Review-Url: https://codereview.chromium.org/2866503002 Cr-Commit-Position: refs/heads/master@{#469759} Committed: https://chromium.googlesource.com/chromium/src/+/5786a2c36b624710f558a12644adeaa93e25dd68

Patch Set 1 #

Patch Set 2 : Add AudioBufferCallback.{h,idl} #

Messages

Total messages: 15 (7 generated)
Raymond Toy
PTAL. mkwst: PTAL at gni files. foolip: FYI. The original change reverted almost cleanly: just ...
3 years, 7 months ago (2017-05-04 19:50:13 UTC) #2
hongchan
lgtm
3 years, 7 months ago (2017-05-04 19:55:28 UTC) #3
Mike West
LGTM.
3 years, 7 months ago (2017-05-05 09:36:36 UTC) #4
foolip
lgtm
3 years, 7 months ago (2017-05-05 11:23:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2866503002/1
3 years, 7 months ago (2017-05-05 14:52:15 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/446203)
3 years, 7 months ago (2017-05-05 14:56:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2866503002/20001
3 years, 7 months ago (2017-05-05 15:17:29 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 19:45:48 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5786a2c36b624710f558a12644ad...

Powered by Google App Engine
This is Rietveld 408576698