PTAL. mkwst: PTAL at gni files. foolip: FYI. The original change reverted almost cleanly: just ...
3 years, 7 months ago
(2017-05-04 19:50:13 UTC)
#2
PTAL.
mkwst: PTAL at gni files.
foolip: FYI.
The original change reverted almost cleanly: just needed a small manual fix for
BaseAudioContext.cpp include files.
hongchan
lgtm
3 years, 7 months ago
(2017-05-04 19:55:28 UTC)
#3
lgtm
Mike West
LGTM.
3 years, 7 months ago
(2017-05-05 09:36:36 UTC)
#4
LGTM.
foolip
lgtm
3 years, 7 months ago
(2017-05-05 11:23:15 UTC)
#5
lgtm
Raymond Toy
The CQ bit was checked by rtoy@chromium.org
3 years, 7 months ago
(2017-05-05 14:51:59 UTC)
#6
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/446203)
3 years, 7 months ago
(2017-05-05 14:56:24 UTC)
#9
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493997418019180, "parent_rev": "f1a3058bf88ee945ab8e5ead543a3b7450710925", "commit_rev": "5786a2c36b624710f558a12644adeaa93e25dd68"}
3 years, 7 months ago
(2017-05-05 19:45:14 UTC)
#13
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493997418019180,
"parent_rev": "f1a3058bf88ee945ab8e5ead543a3b7450710925", "commit_rev":
"5786a2c36b624710f558a12644adeaa93e25dd68"}
commit-bot: I haz the power
Description was changed from ========== Revert removal of AudioBufferCallback Manually revert https://codereview.chromium.org/2820113006/ That CL causes ...
3 years, 7 months ago
(2017-05-05 19:45:47 UTC)
#14
Message was sent while issue was closed.
Description was changed from
==========
Revert removal of AudioBufferCallback
Manually revert https://codereview.chromium.org/2820113006/
That CL causes decodeAudioData callbacks not to be called sometimes.
Apparently, it might be a GC problem where the callbacks are collected
before decodeAudioData calls them.
BUG=717723, 707338
TEST=manually run box2d test and verify convolver.buffer exists
==========
to
==========
Revert removal of AudioBufferCallback
Manually revert https://codereview.chromium.org/2820113006/
That CL causes decodeAudioData callbacks not to be called sometimes.
Apparently, it might be a GC problem where the callbacks are collected
before decodeAudioData calls them.
BUG=717723, 707338
TEST=manually run box2d test and verify convolver.buffer exists
Review-Url: https://codereview.chromium.org/2866503002
Cr-Commit-Position: refs/heads/master@{#469759}
Committed:
https://chromium.googlesource.com/chromium/src/+/5786a2c36b624710f558a12644ad...
==========
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/5786a2c36b624710f558a12644adeaa93e25dd68
3 years, 7 months ago
(2017-05-05 19:45:48 UTC)
#15
Issue 2866503002: Revert removal of AudioBufferCallback
(Closed)
Created 3 years, 7 months ago by Raymond Toy
Modified 3 years, 7 months ago
Reviewers: Mike West, foolip, hongchan
Base URL:
Comments: 0