Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Unified Diff: third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.h

Issue 2866503002: Revert removal of AudioBufferCallback (Closed)
Patch Set: Add AudioBufferCallback.{h,idl} Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.h
diff --git a/third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.h b/third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.h
index a5d7391119fa498bb2b20716ead19649ab162b3f..e5ba08999193066f580dd35be58b450993f7d562 100644
--- a/third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.h
+++ b/third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.h
@@ -34,9 +34,8 @@ namespace blink {
class BaseAudioContext;
class AudioBuffer;
+class AudioBufferCallback;
class AudioBus;
-class DecodeErrorCallback;
-class DecodeSuccessCallback;
class DOMArrayBuffer;
class ScriptPromiseResolver;
@@ -59,8 +58,8 @@ class AsyncAudioDecoder {
// appropriately when finished.
void DecodeAsync(DOMArrayBuffer* audio_data,
float sample_rate,
- DecodeSuccessCallback*,
- DecodeErrorCallback*,
+ AudioBufferCallback* success_callback,
+ AudioBufferCallback* error_callback,
ScriptPromiseResolver*,
BaseAudioContext*);
@@ -68,13 +67,13 @@ class AsyncAudioDecoder {
AudioBuffer* CreateAudioBufferFromAudioBus(AudioBus*);
static void DecodeOnBackgroundThread(DOMArrayBuffer* audio_data,
float sample_rate,
- DecodeSuccessCallback*,
- DecodeErrorCallback*,
+ AudioBufferCallback* success_callback,
+ AudioBufferCallback* error_callback,
ScriptPromiseResolver*,
BaseAudioContext*);
static void NotifyComplete(DOMArrayBuffer* audio_data,
- DecodeSuccessCallback*,
- DecodeErrorCallback*,
+ AudioBufferCallback* success_callback,
+ AudioBufferCallback* error_callback,
AudioBus*,
ScriptPromiseResolver*,
BaseAudioContext*);

Powered by Google App Engine
This is Rietveld 408576698