Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Unified Diff: third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp

Issue 2866503002: Revert removal of AudioBufferCallback (Closed)
Patch Set: Add AudioBufferCallback.{h,idl} Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp b/third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp
index d2ba5b227896cd9dccfa674e6643c61de078d50a..c43bcffcc9ce61d34900f476c4fd85a0e64d1b3e 100644
--- a/third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp
@@ -24,11 +24,9 @@
*/
#include "modules/webaudio/AsyncAudioDecoder.h"
-
-#include "bindings/modules/v8/DecodeErrorCallback.h"
-#include "bindings/modules/v8/DecodeSuccessCallback.h"
#include "core/dom/DOMArrayBuffer.h"
#include "modules/webaudio/AudioBuffer.h"
+#include "modules/webaudio/AudioBufferCallback.h"
#include "modules/webaudio/BaseAudioContext.h"
#include "platform/CrossThreadFunctional.h"
#include "platform/audio/AudioBus.h"
@@ -42,8 +40,8 @@ namespace blink {
void AsyncAudioDecoder::DecodeAsync(DOMArrayBuffer* audio_data,
float sample_rate,
- DecodeSuccessCallback* success_callback,
- DecodeErrorCallback* error_callback,
+ AudioBufferCallback* success_callback,
+ AudioBufferCallback* error_callback,
ScriptPromiseResolver* resolver,
BaseAudioContext* context) {
DCHECK(IsMainThread());
@@ -64,8 +62,8 @@ void AsyncAudioDecoder::DecodeAsync(DOMArrayBuffer* audio_data,
void AsyncAudioDecoder::DecodeOnBackgroundThread(
DOMArrayBuffer* audio_data,
float sample_rate,
- DecodeSuccessCallback* success_callback,
- DecodeErrorCallback* error_callback,
+ AudioBufferCallback* success_callback,
+ AudioBufferCallback* error_callback,
ScriptPromiseResolver* resolver,
BaseAudioContext* context) {
DCHECK(!IsMainThread());
@@ -91,8 +89,8 @@ void AsyncAudioDecoder::DecodeOnBackgroundThread(
}
void AsyncAudioDecoder::NotifyComplete(DOMArrayBuffer*,
- DecodeSuccessCallback* success_callback,
- DecodeErrorCallback* error_callback,
+ AudioBufferCallback* success_callback,
+ AudioBufferCallback* error_callback,
AudioBus* audio_bus,
ScriptPromiseResolver* resolver,
BaseAudioContext* context) {

Powered by Google App Engine
This is Rietveld 408576698