Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 2878243002: Revert of DevTools: format keys in object previews using sans serif. (Closed)

Created:
3 years, 7 months ago by Justin Donnelly
Modified:
3 years, 7 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: format keys in object previews using sans serif. (patchset #3 id:40001 of https://codereview.chromium.org/2866363003/ ) Reason for revert: This change broke webkit_tets on multiple builders. See, for example: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/26454 Original issue's description: > DevTools: format keys in object previews using sans serif. > > NOTRY=try > > Review-Url: https://codereview.chromium.org/2866363003 > Cr-Commit-Position: refs/heads/master@{#471578} > Committed: https://chromium.googlesource.com/chromium/src/+/14981e159fc950c0a628869e85c166c6c09809ca TBR=dgozman@chromium.org,pfeldman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2878243002 Cr-Commit-Position: refs/heads/master@{#471584} Committed: https://chromium.googlesource.com/chromium/src/+/4c12904eb191209d8afda6e28a8ac5293555f3e5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+270 lines, -285 lines) Patch
M third_party/WebKit/LayoutTests/inspector/console/console-call-getter-on-proto-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-copy-truncated-text-expected.txt View 2 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-dir-es6-expected.txt View 2 chunks +15 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-dir-expected.txt View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-eval-undefined-override-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-format-collections-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-format-es6-expected.txt View 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-format-expected.txt View 12 chunks +94 lines, -94 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-functions-expected.txt View 5 chunks +46 lines, -46 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-log-object-with-getter-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-log-short-hand-method-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-log-toString-object-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-native-function-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-object-preview-expected.txt View 1 chunk +36 lines, -36 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-proxy-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-save-to-temp-var-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-tainted-globals-expected.txt View 2 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/extensions/extensions-sidebar-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/debugger-save-to-temp-var-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/show-function-definition-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/properties-special-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPropertiesSection.js View 3 chunks +6 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/object_ui/RemoteObjectPreviewFormatter.js View 3 chunks +8 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/object_ui/objectPropertiesSection.css View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/object_ui/objectValue.css View 2 chunks +1 line, -14 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Justin Donnelly
Created Revert of DevTools: format keys in object previews using sans serif.
3 years, 7 months ago (2017-05-13 16:15:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2878243002/1
3 years, 7 months ago (2017-05-13 16:15:46 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-13 16:16:47 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4c12904eb191209d8afda6e28a8a...

Powered by Google App Engine
This is Rietveld 408576698