Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2097)

Unified Diff: third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPropertiesSection.js

Issue 2866363003: DevTools: format keys in object previews using sans serif. (Closed)
Patch Set: removed the test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPropertiesSection.js
diff --git a/third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPropertiesSection.js b/third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPropertiesSection.js
index c5fa5aad85b625c8f4c35ef13a3c4a0ee2c9fbf5..e2043fb7484920fccd2eaec925e944d1b35ecac9 100644
--- a/third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPropertiesSection.js
+++ b/third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPropertiesSection.js
@@ -152,16 +152,16 @@ ObjectUI.ObjectPropertiesSection = class extends UI.TreeOutlineInShadow {
addElements('class', textAfterPrefix, className);
} else if (isAsync) {
textAfterPrefix = text.substring('async function'.length);
- addElements('async function', textAfterPrefix, nameAndArguments(textAfterPrefix));
+ addElements('async \u0192', textAfterPrefix, nameAndArguments(textAfterPrefix));
} else if (isGenerator) {
textAfterPrefix = text.substring('function*'.length);
- addElements('function*', textAfterPrefix, nameAndArguments(textAfterPrefix));
+ addElements('\u0192*', textAfterPrefix, nameAndArguments(textAfterPrefix));
} else if (isGeneratorShorthand) {
textAfterPrefix = text.substring('*'.length);
- addElements('function*', textAfterPrefix, nameAndArguments(textAfterPrefix));
+ addElements('\u0192*', textAfterPrefix, nameAndArguments(textAfterPrefix));
} else if (isBasic) {
textAfterPrefix = text.substring('function'.length);
- addElements('function', textAfterPrefix, nameAndArguments(textAfterPrefix));
+ addElements('\u0192', textAfterPrefix, nameAndArguments(textAfterPrefix));
} else if (isArrow) {
const maxArrowFunctionCharacterLength = 60;
var abbreviation = text;
@@ -171,7 +171,7 @@ ObjectUI.ObjectPropertiesSection = class extends UI.TreeOutlineInShadow {
abbreviation = text.substring(0, firstArrowIndex + 2) + ' {\u2026}';
addElements('', text, abbreviation);
} else {
- addElements('function', text, nameAndArguments(text));
+ addElements('\u0192', text, nameAndArguments(text));
}
valueElement.title = description || '';
return valueElement;
@@ -738,7 +738,10 @@ ObjectUI.ObjectPropertyTreeElement = class extends UI.TreeElement {
return null;
var valueElement = createElementWithClass('span', 'value');
- valueElement.setTextContentTruncatedIfNeeded(value.description || '');
+ if (value.description === 'Object')
+ valueElement.textContent = '';
+ else
+ valueElement.setTextContentTruncatedIfNeeded(value.description || '');
valueElement.classList.add('object-value-' + (value.subtype || value.type));
valueElement.title = value.description || '';
return valueElement;

Powered by Google App Engine
This is Rietveld 408576698