Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2866363002:
Linux native notifications: Support infinite timeouts (Closed)
|
Created:
3 years, 7 months ago by Tom (Use chromium acct) Modified:
3 years, 7 months ago CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionLinux native notifications: Support infinite timeouts
BUG=676220
R=peter@chromium.org
Review-Url: https://codereview.chromium.org/2866363002
Cr-Commit-Position: refs/heads/master@{#471060}
Committed: https://chromium.googlesource.com/chromium/src/+/2b6becedacaa1f65387896b261ae2103e7b5d145
Patch Set 1 #
Total comments: 2
Patch Set 2 : add unit test #
Total comments: 2
Patch Set 3 : Rebase #
Depends on Patchset: Messages
Total messages: 21 (13 generated)
lgtm % question on https://codereview.chromium.org/2866333002/ https://codereview.chromium.org/2866363002/diff/1/chrome/browser/notification... File chrome/browser/notifications/notification_platform_bridge_linux.cc (right): https://codereview.chromium.org/2866363002/diff/1/chrome/browser/notification... chrome/browser/notifications/notification_platform_bridge_linux.cc:537: const int32_t kExpireTimeoutDefault = -1; qq: is there any way to know what the default timeout is? we timed ~25 seconds as being ideal for transient notifications a bunch of years ago.
thomasanderson@google.com changed reviewers: + thestig@chromium.org
+thestig in case you want to take a look at the unit test https://codereview.chromium.org/2866363002/diff/1/chrome/browser/notification... File chrome/browser/notifications/notification_platform_bridge_linux.cc (right): https://codereview.chromium.org/2866363002/diff/1/chrome/browser/notification... chrome/browser/notifications/notification_platform_bridge_linux.cc:537: const int32_t kExpireTimeoutDefault = -1; On 2017/05/09 22:52:08, Peter Beverloo wrote: > qq: is there any way to know what the default timeout is? we timed ~25 seconds > as being ideal for transient notifications a bunch of years ago. There's no way to know :( We could set the timeout to be 25000, but I think that would confuse/annoy some % of users, so I'd opt to keep it at the default.
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_cronet on master.tryserver.chromium.android (JOB_TIMED_OUT, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
still lgtm https://codereview.chromium.org/2866363002/diff/20001/chrome/browser/notifica... File chrome/browser/notifications/notification_platform_bridge_linux_unittest.cc (right): https://codereview.chromium.org/2866363002/diff/20001/chrome/browser/notifica... chrome/browser/notifications/notification_platform_bridge_linux_unittest.cc:83: int32_t expire_timeout; nit: initialize to 0 since it's a scalar
https://codereview.chromium.org/2866363002/diff/20001/chrome/browser/notifica... File chrome/browser/notifications/notification_platform_bridge_linux_unittest.cc (right): https://codereview.chromium.org/2866363002/diff/20001/chrome/browser/notifica... chrome/browser/notifications/notification_platform_bridge_linux_unittest.cc:83: int32_t expire_timeout; On 2017/05/11 15:47:01, Peter Beverloo wrote: > nit: initialize to 0 since it's a scalar Done.
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by thomasanderson@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org, thestig@chromium.org Link to the patchset: https://codereview.chromium.org/2866363002/#ps40001 (title: "Rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494534391536330,
"parent_rev": "2a53c065addcdea227e78a5d9d7c3be69c129ecf", "commit_rev":
"2b6becedacaa1f65387896b261ae2103e7b5d145"}
Message was sent while issue was closed.
Description was changed from ========== Linux native notifications: Support infinite timeouts BUG=676220 R=peter@chromium.org ========== to ========== Linux native notifications: Support infinite timeouts BUG=676220 R=peter@chromium.org Review-Url: https://codereview.chromium.org/2866363002 Cr-Commit-Position: refs/heads/master@{#471060} Committed: https://chromium.googlesource.com/chromium/src/+/2b6becedacaa1f65387896b261ae... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/2b6becedacaa1f65387896b261ae... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
