Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2875443002:
Linux native notifications: Support list notifications (Closed)
|
Created:
3 years, 7 months ago by Tom (Use chromium acct) Modified:
3 years, 7 months ago CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionLinux native notifications: Support list notifications
BUG=676220
R=peter@chromium.org
Review-Url: https://codereview.chromium.org/2875443002
Cr-Commit-Position: refs/heads/master@{#471053}
Committed: https://chromium.googlesource.com/chromium/src/+/ed102436bc09f3e463af6974efec366c4e8423d0
Patch Set 1 #
Total comments: 4
Patch Set 2 : Refactor #Patch Set 3 : Rebase #
Dependent Patchsets: Messages
Total messages: 23 (14 generated)
lgtm % question on https://codereview.chromium.org/2866333002/ https://codereview.chromium.org/2875443002/diff/1/chrome/browser/notification... File chrome/browser/notifications/notification_platform_bridge_linux.cc (right): https://codereview.chromium.org/2875443002/diff/1/chrome/browser/notification... chrome/browser/notifications/notification_platform_bridge_linux.cc:456: body += "<b>" + title + "</b> " + message; Could you add a TODO (in my name if you prefer) to figure out the right way to internationalize this? We're doing this on all platforms, including the Message Center, so there wouldn't be a regression, but I *think* this needs to be flipped around for RTL languages. https://codereview.chromium.org/2875443002/diff/1/chrome/browser/notification... chrome/browser/notifications/notification_platform_bridge_linux.cc:458: body += title + " - " + message; Does the newline (:452) work even for notification centers that don't support body markup?
thomasanderson@google.com changed reviewers: + thestig@chromium.org
+thestig for notification_platform_bridge_linux_unittest.cc https://codereview.chromium.org/2875443002/diff/1/chrome/browser/notification... File chrome/browser/notifications/notification_platform_bridge_linux.cc (right): https://codereview.chromium.org/2875443002/diff/1/chrome/browser/notification... chrome/browser/notifications/notification_platform_bridge_linux.cc:456: body += "<b>" + title + "</b> " + message; On 2017/05/09 22:52:04, Peter Beverloo wrote: > Could you add a TODO (in my name if you prefer) to figure out the right way to > internationalize this? We're doing this on all platforms, including the Message > Center, so there wouldn't be a regression, but I *think* this needs to be > flipped around for RTL languages. Done. https://codereview.chromium.org/2875443002/diff/1/chrome/browser/notification... chrome/browser/notifications/notification_platform_bridge_linux.cc:458: body += title + " - " + message; On 2017/05/09 22:52:04, Peter Beverloo wrote: > Does the newline (:452) work even for notification centers that don't support > body markup? Yes
The CQ bit was checked by thomasanderson@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org Link to the patchset: https://codereview.chromium.org/2875443002/#ps20001 (title: "Refactor")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
The CQ bit was checked by thomasanderson@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by thomasanderson@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org Link to the patchset: https://codereview.chromium.org/2875443002/#ps40001 (title: "Rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494533205333340,
"parent_rev": "dbffa1f17ed75a9376cafd7ff7c76206222771e6", "commit_rev":
"ed102436bc09f3e463af6974efec366c4e8423d0"}
Message was sent while issue was closed.
Description was changed from ========== Linux native notifications: Support list notifications BUG=676220 R=peter@chromium.org ========== to ========== Linux native notifications: Support list notifications BUG=676220 R=peter@chromium.org Review-Url: https://codereview.chromium.org/2875443002 Cr-Commit-Position: refs/heads/master@{#471053} Committed: https://chromium.googlesource.com/chromium/src/+/ed102436bc09f3e463af6974efec... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/ed102436bc09f3e463af6974efec... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
