Linux native notifications: Support infinite timeouts

chrome/browser/notifications/notification_platform_bridge_linux.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/notifications/notification_platform_bridge_linux.h"
 
 #include <algorithm>
 #include <memory>
 #include <set>
 #include <unordered_map>
@@ skipping 516 matching lines @@
           spec_version_ == base::Version(std::vector<uint32_t>{1, 1})
               ? "image_path"
               : "image-path");
       image_path_writer.AppendVariantOfString(icon_file->file_path().value());
       hints_writer.CloseContainer(&image_path_writer);
       data->resource_files.push_back(std::move(icon_file));
     }
 
     writer.CloseContainer(&hints_writer);
 
     const int32_t kExpireTimeoutDefault = -1;

[Peter Beverloo, 2017/05/09 22:52:08]

qq: is there any way to know what the default timeout is? we timed ~25 seconds
as being ideal for transient notifications a bunch of years ago.

[Tom (Use chromium acct), 2017/05/10 21:20:58]

There's no way to know :(  We could set the timeout to be 25000, but I think
that would confuse/annoy some % of users, so I'd opt to keep it at the default.

-    writer.AppendInt32(kExpireTimeoutDefault);
+    const int32_t kExpireTimeoutNever = 0;
+    writer.AppendInt32(notification->never_timeout() ? kExpireTimeoutNever
+                                                     : kExpireTimeoutDefault);
 
     std::unique_ptr<dbus::Response> response =
         notification_proxy_->CallMethodAndBlock(
             &method_call, dbus::ObjectProxy::TIMEOUT_USE_DEFAULT);
     if (response) {
       dbus::MessageReader reader(response.get());
       reader.PopUint32(&data->dbus_id);
     }
     if (!data->dbus_id) {
       // There was some sort of error with creating the notification.
@@ skipping 255 matching lines @@
 }
 
 void NotificationPlatformBridgeLinux::SetReadyCallback(
     NotificationBridgeReadyCallback callback) {
   impl_->SetReadyCallback(std::move(callback));
 }
 
 void NotificationPlatformBridgeLinux::CleanUp() {
   impl_->CleanUp();
 }