[LayoutNG] Inline margin/border/padding, inter-item breaking, and tests

[LayoutNG] Inline margin/border/padding, inter-item breaking, and tests

This patch implements inline margin/border/padding. NGTextFragment is
placed according to these properties. The border is not reflected to
fragment tree yet, adding NGBoxFragments will be in following patches.

This patch also supports when inter-item is not breakable. Inline
margin/border/padding belong to different NGInlineItem than its
text, but between them are not breakable.

Includes a fix for LazyLineBreakIterator where offset 0 should not be
breakable.

This patch also adds tests when inter-items are not breakable.

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng

Review-Url: https://codereview.chromium.org/2865903002
Cr-Commit-Position: refs/heads/master@{#475799}
Committed: https://chromium.googlesource.com/chromium/src/+/ec0c017a410d4c51bfdc3a0d3423d2cff3c6f064

[kojii, 2017-05-15 07:27:26]

Description was changed from

==========
nginlinemargin

BUG=
==========

to

==========
nginlinemargin

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

[kojii, 2017-05-22 11:38:00]

Description was changed from

==========
nginlinemargin

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

to

==========
[LayoutNG] Inline margin/border/padding, inter-item breaking, and tests

This patch implements inline margin/border/padding. NGTextFragment is
placed according to these properties. The border is not reflected to
fragment tree yet, adding NGBoxFragments will be in following patches.

It revealed that inter-item breaking is not well supported yet, because
inline margin/border/padding belong to different NGInlineItem than its
text, but between them are not breakable.

NGLineBreaker got large overhaul to support when two NGInlineItems are
not breakable.

It also means that tests for non-breakable inter-items do not exist.
This patch adds some common such cases.

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

[kojii, 2017-05-22 12:45:43]

Description was changed from

==========
[LayoutNG] Inline margin/border/padding, inter-item breaking, and tests

This patch implements inline margin/border/padding. NGTextFragment is
placed according to these properties. The border is not reflected to
fragment tree yet, adding NGBoxFragments will be in following patches.

It revealed that inter-item breaking is not well supported yet, because
inline margin/border/padding belong to different NGInlineItem than its
text, but between them are not breakable.

NGLineBreaker got large overhaul to support when two NGInlineItems are
not breakable.

It also means that tests for non-breakable inter-items do not exist.
This patch adds some common such cases.

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

to

==========
[LayoutNG] Inline margin/border/padding, inter-item breaking, and tests

This patch implements inline margin/border/padding. NGTextFragment is
placed according to these properties. The border is not reflected to
fragment tree yet, adding NGBoxFragments will be in following patches.

It revealed that inter-item breaking is not well supported yet, because
inline margin/border/padding belong to different NGInlineItem than its
text, but between them are not breakable.

NGLineBreaker got large overhaul to support when two NGInlineItems are
not breakable.

This patch also adds some tests for non-breakable inter-items.

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

[kojii, 2017-05-22 12:55:04]

Description was changed from

==========
[LayoutNG] Inline margin/border/padding, inter-item breaking, and tests

This patch implements inline margin/border/padding. NGTextFragment is
placed according to these properties. The border is not reflected to
fragment tree yet, adding NGBoxFragments will be in following patches.

It revealed that inter-item breaking is not well supported yet, because
inline margin/border/padding belong to different NGInlineItem than its
text, but between them are not breakable.

NGLineBreaker got large overhaul to support when two NGInlineItems are
not breakable.

This patch also adds some tests for non-breakable inter-items.

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

to

==========
[LayoutNG] Inline margin/border/padding, inter-item breaking, and tests

This patch implements inline margin/border/padding. NGTextFragment is
placed according to these properties. The border is not reflected to
fragment tree yet, adding NGBoxFragments will be in following patches.

It revealed that inter-item breaking is not well supported yet, because
inline margin/border/padding belong to different NGInlineItem than its
text, but between them are not breakable.

NGLineBreaker got large overhaul to support when two NGInlineItems are
not breakable.

Includes a fix for LazyLineBreakIterator where offset 0 should not be
breakable.

This patch also adds some tests for non-breakable inter-items.

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

[kojii, 2017-05-22 14:53:59]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 14:54:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-05-22 15:53:46]

Description was changed from

==========
[LayoutNG] Inline margin/border/padding, inter-item breaking, and tests

This patch implements inline margin/border/padding. NGTextFragment is
placed according to these properties. The border is not reflected to
fragment tree yet, adding NGBoxFragments will be in following patches.

It revealed that inter-item breaking is not well supported yet, because
inline margin/border/padding belong to different NGInlineItem than its
text, but between them are not breakable.

NGLineBreaker got large overhaul to support when two NGInlineItems are
not breakable.

Includes a fix for LazyLineBreakIterator where offset 0 should not be
breakable.

This patch also adds some tests for non-breakable inter-items.

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

to

==========
[LayoutNG] Inline margin/border/padding, inter-item breaking, and tests

This patch implements inline margin/border/padding. NGTextFragment is
placed according to these properties. The border is not reflected to
fragment tree yet, adding NGBoxFragments will be in following patches.

This patch also supports when inter-item is not breakable. Inline
margin/border/padding belong to different NGInlineItem than its
text, but between them are not breakable.

Includes a fix for LazyLineBreakIterator where offset 0 should not be
breakable.

This patch also adds some tests for non-breakable inter-items.

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

[kojii, 2017-05-22 15:55:19]

Description was changed from

==========
[LayoutNG] Inline margin/border/padding, inter-item breaking, and tests

This patch implements inline margin/border/padding. NGTextFragment is
placed according to these properties. The border is not reflected to
fragment tree yet, adding NGBoxFragments will be in following patches.

This patch also supports when inter-item is not breakable. Inline
margin/border/padding belong to different NGInlineItem than its
text, but between them are not breakable.

Includes a fix for LazyLineBreakIterator where offset 0 should not be
breakable.

This patch also adds some tests for non-breakable inter-items.

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

to

==========
[LayoutNG] Inline margin/border/padding, inter-item breaking, and tests

This patch implements inline margin/border/padding. NGTextFragment is
placed according to these properties. The border is not reflected to
fragment tree yet, adding NGBoxFragments will be in following patches.

This patch also supports when inter-item is not breakable. Inline
margin/border/padding belong to different NGInlineItem than its
text, but between them are not breakable.

Includes a fix for LazyLineBreakIterator where offset 0 should not be
breakable.

This patch also adds tests when inter-items are not breakable.

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

[kojii, 2017-05-22 16:04:16]

kojii@chromium.org changed reviewers:
+ eae@chromium.org, ikilpatrick@chromium.org

[kojii, 2017-05-22 16:04:17]

PTAL. This turned out to be larger than expected. Some tests maybe still
failing, but I think it's ready for review.

Break around objects isn't well-defined and I expect we'll need more tweaks for
web-compat by testing and reviewing the legacy code. This patch has some
behavior closer to Edge/Gecko than the current line breaker, I'm going to do
more testing and add tests.

[kojii, 2017-05-22 18:51:33]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 18:52:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cbiesinger, 2017-05-22 19:02:58]

cbiesinger@chromium.org changed reviewers:
+ cbiesinger@chromium.org

[cbiesinger, 2017-05-22 19:02:59]

https://codereview.chromium.org/2865903002/diff/200001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc (right):

https://codereview.chromium.org/2865903002/diff/200001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc:399: LayoutUnit
ComputeMarginBorderPaddingInlineStart(
I'd rather not add functions like these; why not use:

  (ComputeMargins() + ComputeBorders() + ComputePadding()).inline_start?

NGBoxStrut has an operator+ for that specific purpose.

[kojii, 2017-05-22 19:22:42]

https://codereview.chromium.org/2865903002/diff/200001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc (right):

https://codereview.chromium.org/2865903002/diff/200001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc:399: LayoutUnit
ComputeMarginBorderPaddingInlineStart(
On 2017/05/22 at 19:02:58, cbiesinger wrote:
> I'd rather not add functions like these; why not use:
> 
>   (ComputeMargins() + ComputeBorders() + ComputePadding()).inline_start?
> 
> NGBoxStrut has an operator+ for that specific purpose.

It computes 4 values and discard 3 out of that. I'm ok to add 6 functions
(margin/border/padding * start/end) and the caller to sum them. Is that better?

Or is computing unnecessary 3 values ok?

[kojii, 2017-05-22 19:26:31]

https://codereview.chromium.org/2865903002/diff/200001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc (right):

https://codereview.chromium.org/2865903002/diff/200001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc:399: LayoutUnit
ComputeMarginBorderPaddingInlineStart(
BTW, you might know but in case, the legacy has MarginBorderPaddingLogicalLeft()
etc. for inline, because when inline, inline direction and block direction are
used in different phases.
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/li...

[cbiesinger, 2017-05-22 20:41:10]

I think for now we should try to keep the API simpler. These functions are all
fairly cheap, O(1) unlike the legacy versions. If this turns out to be too
costly we can change things around.

[commit-bot: I haz the power, 2017-05-22 20:53:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 20:53:25]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_layout_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))

[kojii, 2017-05-23 04:14:06]

On 2017/05/22 at 20:41:10, cbiesinger wrote:
> I think for now we should try to keep the API simpler. These functions are all
fairly cheap, O(1) unlike the legacy versions. If this turns out to be too
costly we can change things around.

Ok, I'll change it for now and make the perf later. If we want to keep the API
simpler, I think we should try common-denominator; split inline and block, and
block code should call twice. But I don't think we need to pursue one way or the
other at this point.

[kojii, 2017-05-23 04:31:18]

Or I can cache this since its quite transitional, from the beginning of line
breaking until line boxes are built. Not in this patch though.

[kojii, 2017-05-23 04:32:21]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[kojii, 2017-05-23 04:32:40]

Done, PTAL.

[commit-bot: I haz the power, 2017-05-23 04:32:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-05-23 04:44:31]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 04:44:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 08:32:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 08:32:12]

Dry run: This issue passed the CQ dry run.

[cbiesinger, 2017-05-23 18:30:43]

Thank you! I like this better. I'll leave the actual review of the inline layout
change to someone who knows the code better.

[ikilpatrick, 2017-05-24 04:03:39]

sorry for the slow review, I'll do another pass in the morning if thats ok, but
broadly looks good.

https://codereview.chromium.org/2865903002/diff/260001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item_result.h
(right):

https://codereview.chromium.org/2865903002/diff/260001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item_result.h:46: //
Used only during the line breaking.
Used only during line breaking.

(& below).

https://codereview.chromium.org/2865903002/diff/260001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker.cc (right):

https://codereview.chromium.org/2865903002/diff/260001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker.cc:408: void
NGLineBreaker::UpdateStyle(const ComputedStyle& style) {
can this be renamed? I got concerned initially that this was changed the
computedstyle object.

[kojii, 2017-05-24 15:50:55]

> sorry for the slow review, I'll do another pass in the morning if thats ok,
but broadly looks good.

Not at all, this turned out to be big that hardly expect too fast review, but
I'm so glad you had a look and "broadly looks good" is very pleasure to me ;)

https://codereview.chromium.org/2865903002/diff/260001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item_result.h
(right):

https://codereview.chromium.org/2865903002/diff/260001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item_result.h:46: //
Used only during the line breaking.
On 2017/05/24 at 04:03:38, ikilpatrick wrote:
> Used only during line breaking.
> 
> (& below).

Thank you, articles are not easy for me...

https://codereview.chromium.org/2865903002/diff/260001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker.cc (right):

https://codereview.chromium.org/2865903002/diff/260001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker.cc:408: void
NGLineBreaker::UpdateStyle(const ComputedStyle& style) {
On 2017/05/24 at 04:03:39, ikilpatrick wrote:
> can this be renamed? I got concerned initially that this was changed the
computedstyle object.

How about "UpdateBreakIterator"? I was using it until this updates auto_wrap_,
but with your feedback, I understand this looks like it updates style...

[kojii, 2017-05-24 16:17:04]

Patchset #15 (id:280001) has been deleted

[kojii, 2017-05-24 16:25:16]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 16:25:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-05-24 16:41:36]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[kojii, 2017-05-24 16:41:56]

Patchset #15 (id:300001) has been deleted

[commit-bot: I haz the power, 2017-05-24 16:42:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-05-24 16:49:50]

Patchset #15 (id:320001) has been deleted

[kojii, 2017-05-24 17:00:43]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 17:01:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 19:02:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 19:02:58]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_layout_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))

[kojii, 2017-05-28 19:09:39]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-28 19:09:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-28 22:38:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-28 22:38:51]

Dry run: This issue passed the CQ dry run.

[kojii, 2017-05-29 05:26:33]

Gentle reminder in case this was forgotten...

In the mean time, Alex cleaning up TestExpectations found a bug in computing the
inline size, fixed in PS16.

[kojii, 2017-05-29 13:12:19]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-29 13:12:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 15:45:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-29 15:45:19]

Dry run: This issue passed the CQ dry run.

[eae, 2017-05-30 15:12:24]

LGTM for line breaker and inline logic

[ikilpatrick, 2017-05-30 16:05:27]

lgtm

https://codereview.chromium.org/2865903002/diff/380001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item.cc (right):

https://codereview.chromium.org/2865903002/diff/380001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item.cc:129: return
!GetLayoutObject()->IsInlineElementContinuation();
These should be switch to break token checks at some point? Maybe just a TODO
for the moment for these functions.

https://codereview.chromium.org/2865903002/diff/380001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker.cc (right):

https://codereview.chromium.org/2865903002/diff/380001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker.cc:99: while
(item_index_ < items.size()) {
If i get time this week i'll play with pulling this up to the algorithm just to
see what it looks like.

https://codereview.chromium.org/2865903002/diff/380001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker_test.cc
(right):

https://codereview.chromium.org/2865903002/diff/380001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker_test.cc:225:
<!DOCTYPE html>
we've been indenting these.

https://codereview.chromium.org/2865903002/diff/380001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/text/TextBreakIterator.cpp (right):

https://codereview.chromium.org/2865903002/diff/380001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/text/TextBreakIterator.cpp:395:
IsBreakable(offset, next_break);
Can just be IsBreakable(offset) ?

[kojii, 2017-05-30 17:56:16]

The CQ bit was checked by kojii@chromium.org

[kojii, 2017-05-30 17:56:18]

Thank you for your review!

https://codereview.chromium.org/2865903002/diff/380001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item.cc (right):

https://codereview.chromium.org/2865903002/diff/380001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item.cc:129: return
!GetLayoutObject()->IsInlineElementContinuation();
On 2017/05/30 at 16:05:26, ikilpatrick wrote:
> These should be switch to break token checks at some point? Maybe just a TODO
for the moment for these functions.

Done.

https://codereview.chromium.org/2865903002/diff/380001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker.cc (right):

https://codereview.chromium.org/2865903002/diff/380001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker.cc:99: while
(item_index_ < items.size()) {
On 2017/05/30 at 16:05:26, ikilpatrick wrote:
> If i get time this week i'll play with pulling this up to the algorithm just
to see what it looks like.

Sounds good, will work on other files this week.

https://codereview.chromium.org/2865903002/diff/380001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker_test.cc
(right):

https://codereview.chromium.org/2865903002/diff/380001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker_test.cc:225:
<!DOCTYPE html>
On 2017/05/30 at 16:05:26, ikilpatrick wrote:
> we've been indenting these.

Done, didn't check other files, thank you!

https://codereview.chromium.org/2865903002/diff/380001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/text/TextBreakIterator.cpp (right):

https://codereview.chromium.org/2865903002/diff/380001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/text/TextBreakIterator.cpp:395:
IsBreakable(offset, next_break);
On 2017/05/30 at 16:05:26, ikilpatrick wrote:
> Can just be IsBreakable(offset) ?

I need to return next_break (this is reference) here, so let me leave this as
is.

[kojii, 2017-05-30 17:56:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
ikilpatrick@chromium.org, eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2865903002/#ps400001
(title: "ikilpatrick review")

[commit-bot: I haz the power, 2017-05-30 17:56:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 19:20:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 19:20:47]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kojii, 2017-05-31 01:35:55]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2017-05-31 01:36:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 04:26:52]

CQ is committing da patch.

Bot data: {"patchset_id": 400001, "attempt_start_ts": 1496194555671750,
"parent_rev": "f14ac82cdb0d6e6953e59558e0f2884ca8bf89c8", "commit_rev":
"ec0c017a410d4c51bfdc3a0d3423d2cff3c6f064"}

[commit-bot: I haz the power, 2017-05-31 04:27:03]

Description was changed from

==========
[LayoutNG] Inline margin/border/padding, inter-item breaking, and tests

This patch implements inline margin/border/padding. NGTextFragment is
placed according to these properties. The border is not reflected to
fragment tree yet, adding NGBoxFragments will be in following patches.

This patch also supports when inter-item is not breakable. Inline
margin/border/padding belong to different NGInlineItem than its
text, but between them are not breakable.

Includes a fix for LazyLineBreakIterator where offset 0 should not be
breakable.

This patch also adds tests when inter-items are not breakable.

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

to

==========
[LayoutNG] Inline margin/border/padding, inter-item breaking, and tests

This patch implements inline margin/border/padding. NGTextFragment is
placed according to these properties. The border is not reflected to
fragment tree yet, adding NGBoxFragments will be in following patches.

This patch also supports when inter-item is not breakable. Inline
margin/border/padding belong to different NGInlineItem than its
text, but between them are not breakable.

Includes a fix for LazyLineBreakIterator where offset 0 should not be
breakable.

This patch also adds tests when inter-items are not breakable.

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng

Review-Url: https://codereview.chromium.org/2865903002
Cr-Commit-Position: refs/heads/master@{#475799}
Committed:
https://chromium.googlesource.com/chromium/src/+/ec0c017a410d4c51bfdc3a0d3423...
==========

[commit-bot: I haz the power, 2017-05-31 04:27:06]

Committed patchset #18 (id:400001) as
https://chromium.googlesource.com/chromium/src/+/ec0c017a410d4c51bfdc3a0d3423...