third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.cc - Issue 2865903002: [LayoutNG] Inline margin/border/padding, inter-item breaking, and tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.cc

Issue 2865903002: [LayoutNG] Inline margin/border/padding, inter-item breaking, and tests (Closed)

Patch Set: ikilpatrick review Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item_result.cc ('k') | third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.cc b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.cc

index f9b7422e2f6b6cb8f80074d41933ab761be24b85..922d36852ca2490383362659e2c94e14753bcd14 100644

--- a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.cc

+++ b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.cc

@@ -272,8 +272,10 @@ bool NGInlineLayoutAlgorithm::PlaceItems(

borders.BlockSum() + paddings.BlockSum());

}

} else if (item.Type() == NGInlineItem::kCloseTag) {

+ position += item_result.inline_size;

box = box_states_.OnCloseTag(item, &line_box, box, baseline_type_,

position);

+ continue;

} else if (item.Type() == NGInlineItem::kAtomicInline) {

box = PlaceAtomicInline(item, &item_result, position, &line_box,

&text_builder);