[LayoutNG] Inline margin/border/padding, inter-item breaking, and tests

third_party/WebKit/Source/platform/text/TextBreakIterator.cpp

 /*
  * (C) 1999 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2010 Apple Inc. All rights
  * reserved.
  * Copyright (C) 2007-2009 Torch Mobile, Inc.
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 373 matching lines @@
 
 int LazyLineBreakIterator::NextBreakablePositionKeepAll(int pos) const {
   if (string_.Is8Bit())
     return NextBreakablePosition<LChar, LineBreakType::kNormal>(
         *this, string_.Characters8(), string_.length(), pos);
   return NextBreakablePositionKeepAllInternal(*this, string_.Characters16(),
                                               string_.length(), pos);
 }
 
 unsigned LazyLineBreakIterator::NextBreakOpportunity(unsigned offset) const {
-  int next_break = 0;
+  int next_break = -1;
   IsBreakable(offset, next_break);

[ikilpatrick, 2017/05/30 16:05:26]

Can just be IsBreakable(offset) ?

[kojii, 2017/05/30 17:56:18]

I need to return next_break (this is reference) here, so let me leave this as
is.

   return next_break;
 }
 
 unsigned LazyLineBreakIterator::PreviousBreakOpportunity(unsigned offset,
                                                          unsigned min) const {
   unsigned pos = std::min(offset, string_.length());
   for (; pos > min; pos--) {
-    int next_break = 0;
-    if (IsBreakable(pos, next_break))
+    if (IsBreakable(pos))
       return pos;
   }
   return min;
 }
 
 }  // namespace blink