Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2865723002:
Reland of: WebUI: Disable all JS tests in MSAN, ASAN, and TSAN bots. (Closed)
DescriptionReland of: WebUI: Disable all JS tests in MSAN, ASAN, and TSAN bots.
There is not a lot of benefit of running WebUI JS tests on *SAN bots
(a lot of tests exceed the allowed timeout and have been disabled already).
Previously at crrev.com/2690303003, all MD Settings tests were disabled
for ASAN bots. This CL does the same for MSAN, TSAN and for all WebUI tests.
Previous attempt was at crrev.com/2760693002.
BUG=579666
Review-Url: https://codereview.chromium.org/2865723002
Cr-Commit-Position: refs/heads/master@{#470637}
Committed: https://chromium.googlesource.com/chromium/src/+/72e1320b61aee9925689e6b2b194e5599cc33dbf
Patch Set 1 #Patch Set 2 : Fix android maybe #Patch Set 3 : Resolve conflict #
Total comments: 4
Patch Set 4 : Address comment. #Messages
Total messages: 35 (27 generated)
The CQ bit was checked by dpapad@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Reland of: WebUI: Disable all JS tests in MSAN, ASAN, and TSAN bots. There is not a lot of benefit of running WebUI JS tests on *SAN bots. Previously at crrev.com/2690303003, all MD Settings tests were disabled for ASAN bots. This CL does the same for MSAN, TSAN and for all WebUI tests. BUG=579666 ========== to ========== Reland of: WebUI: Disable all JS tests in MSAN, ASAN, and TSAN bots. There is not a lot of benefit of running WebUI JS tests on *SAN bots. Previously at crrev.com/2690303003, all MD Settings tests were disabled for ASAN bots. This CL does the same for MSAN, TSAN and for all WebUI tests. Previous attempt was at crrev.com/2760693002. BUG=579666 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
The CQ bit was checked by dpapad@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by dpapad@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dpapad@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
@thestig: Is there a way to trigger isolate_tests before actually landing this change (either a tryjob or run it locally)? It had originally been reverted because it caused failures on such bots see https://codereview.chromium.org/2760693002#msg29.
On 2017/05/08 20:43:00, dpapad wrote: > @thestig: Is there a way to trigger isolate_tests before actually landing this > change (either a tryjob or run it locally)? It had originally been reverted > because it caused failures on such bots see > https://codereview.chromium.org/2760693002#msg29. If you look at the non-compile-only try jobs, they have an "isolate tests" step. The mystery is how your previous attempt passed trybots, but caused later trybots to fail.
dpapad@chromium.org changed reviewers: + dbeam@chromium.org
Newly re-enabled settings-main test already started failing on MSAN bots, see https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=Cr....
Friendly ping.
lgtm w/not mandatory nit ;) https://codereview.chromium.org/2865723002/diff/40001/chrome/test/BUILD.gn File chrome/test/BUILD.gn (right): https://codereview.chromium.org/2865723002/diff/40001/chrome/test/BUILD.gn#ne... chrome/test/BUILD.gn:28: skip_js_tests = is_asan || is_msan || is_tsan can we invert this to include_js_tests = !(is_asan || is_msan || is_tsan) https://codereview.chromium.org/2865723002/diff/40001/chrome/test/BUILD.gn#ne... chrome/test/BUILD.gn:500: if (!skip_js_tests) { if (include_js_tests) {
The CQ bit was checked by dpapad@chromium.org to run a CQ dry run
https://codereview.chromium.org/2865723002/diff/40001/chrome/test/BUILD.gn File chrome/test/BUILD.gn (right): https://codereview.chromium.org/2865723002/diff/40001/chrome/test/BUILD.gn#ne... chrome/test/BUILD.gn:28: skip_js_tests = is_asan || is_msan || is_tsan On 2017/05/10 at 00:02:29, Dan Beam wrote: > can we invert this to > > include_js_tests = !(is_asan || is_msan || is_tsan) Done. https://codereview.chromium.org/2865723002/diff/40001/chrome/test/BUILD.gn#ne... chrome/test/BUILD.gn:500: if (!skip_js_tests) { On 2017/05/10 at 00:02:29, Dan Beam wrote: > if (include_js_tests) { Done.
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Reland of: WebUI: Disable all JS tests in MSAN, ASAN, and TSAN bots. There is not a lot of benefit of running WebUI JS tests on *SAN bots. Previously at crrev.com/2690303003, all MD Settings tests were disabled for ASAN bots. This CL does the same for MSAN, TSAN and for all WebUI tests. Previous attempt was at crrev.com/2760693002. BUG=579666 ========== to ========== Reland of: WebUI: Disable all JS tests in MSAN, ASAN, and TSAN bots. There is not a lot of benefit of running WebUI JS tests on *SAN bots (a lot of tests exceed the allowed timeout and have been disabled already). Previously at crrev.com/2690303003, all MD Settings tests were disabled for ASAN bots. This CL does the same for MSAN, TSAN and for all WebUI tests. Previous attempt was at crrev.com/2760693002. BUG=579666 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?))
The CQ bit was checked by dpapad@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org Link to the patchset: https://codereview.chromium.org/2865723002/#ps60001 (title: "Address comment.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494437844724200,
"parent_rev": "14bed0b13cd9a3620834c6cb6a00cfddacfb8eff", "commit_rev":
"72e1320b61aee9925689e6b2b194e5599cc33dbf"}
Message was sent while issue was closed.
Description was changed from ========== Reland of: WebUI: Disable all JS tests in MSAN, ASAN, and TSAN bots. There is not a lot of benefit of running WebUI JS tests on *SAN bots (a lot of tests exceed the allowed timeout and have been disabled already). Previously at crrev.com/2690303003, all MD Settings tests were disabled for ASAN bots. This CL does the same for MSAN, TSAN and for all WebUI tests. Previous attempt was at crrev.com/2760693002. BUG=579666 ========== to ========== Reland of: WebUI: Disable all JS tests in MSAN, ASAN, and TSAN bots. There is not a lot of benefit of running WebUI JS tests on *SAN bots (a lot of tests exceed the allowed timeout and have been disabled already). Previously at crrev.com/2690303003, all MD Settings tests were disabled for ASAN bots. This CL does the same for MSAN, TSAN and for all WebUI tests. Previous attempt was at crrev.com/2760693002. BUG=579666 Review-Url: https://codereview.chromium.org/2865723002 Cr-Commit-Position: refs/heads/master@{#470637} Committed: https://chromium.googlesource.com/chromium/src/+/72e1320b61aee9925689e6b2b194... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/72e1320b61aee9925689e6b2b194... |
