Reland of: WebUI: Disable all JS tests in MSAN, ASAN, and TSAN bots.

chrome/test/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chrome_build.gni")
 import("//build/config/compiler/compiler.gni")
 import("//build/config/crypto.gni")
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 import("//chrome/common/features.gni")
 import("//chrome/chrome_repack_locales.gni")
 import("//components/os_crypt/features.gni")
 import("//components/spellcheck/spellcheck_build_features.gni")
 import("//extensions/features/features.gni")
 import("//media/media_options.gni")
 import("//ppapi/features/features.gni")
 import("//remoting/remoting_enable.gni")
 import("//rlz/features/features.gni")
 import("//services/service_manager/public/service_manifest.gni")
 import("//services/catalog/public/tools/catalog.gni")
 import("//testing/test.gni")
 import("//ui/base/ui_features.gni")
 import("//v8/gni/v8.gni")
 
 if (is_android) {
   import("//build/config/android/rules.gni")
+} else {
+  skip_js_tests = is_asan || is_msan || is_tsan

[Dan Beam, 2017/05/10 00:02:29]

can we invert this to

include_js_tests = !(is_asan || is_msan || is_tsan)

[dpapad, 2017/05/10 00:06:38]

Done.

 }
 
 # This target exists to reference other test executables to bring these files
 # into the build.
 group("test") {
   testonly = true
 }
 
 # Use a static library here because many test binaries depend on this but don't
 # require many files from it. This makes linking more efficient.
@@ skipping 427 matching lines @@
 
     deps = [
       ":test_support",
       ":test_support_ui",
       "//chrome:packed_resources",
       "//chrome:resources",
       "//chrome:strings",
       "//chrome/browser",
       "//chrome/browser/devtools",
       "//chrome/renderer",
-      "//chrome/test/data/webui:interactive_ui_tests_js_webui",
       "//components/resources",
       "//components/sync",
       "//components/sync:test_support_model",
       "//content/app/resources",
       "//content/test:test_support",
       "//crypto:platform",
       "//crypto:test_support",
       "//extensions/features",
       "//google_apis:test_support",
       "//net",
       "//net:net_resources",
       "//net:test_support",
       "//skia",
       "//testing/gmock",
       "//testing/gtest",
       "//third_party/hunspell",
       "//third_party/icu",
       "//third_party/libpng",
       "//third_party/zlib",
       "//ui/base:test_support",
       "//ui/resources:ui_test_pak",
       "//ui/web_dialogs:test_support",
     ]
 
+    if (!skip_js_tests) {

[Dan Beam, 2017/05/10 00:02:29]

if (include_js_tests) {

[dpapad, 2017/05/10 00:06:38]

Done.

+      deps += [ "//chrome/test/data/webui:interactive_ui_tests_js_webui" ]
+    }
+
     # TODO(rockot) bug 505926: The chrome_extensions_interactive_uitests target
     # should be deleted and this line removed. See the
     # chrome_extensions_interactive_uitests target for more.
     deps += [ "//extensions:chrome_extensions_interactive_uitests" ]
 
     # Runtime dependencies
     data_deps += [
       "//ppapi:ppapi_tests",
       "//third_party/mesa:osmesa",
     ]
@@ skipping 1213 matching lines @@
       ":sync_integration_test_support",
       ":test_support_ui",
       "//base:i18n",
       "//base/test:test_support",
       "//chrome:browser_tests_pak",
       "//chrome:packed_resources",
       "//chrome:resources",
       "//chrome:strings",
       "//chrome/browser",
       "//chrome/renderer",
-      "//chrome/test/data/webui:browser_tests_js_webui",
       "//chrome/test/media_router:media_router_browsertests",
       "//components/autofill/content/browser:risk_proto",
       "//components/autofill/content/renderer:test_support",
       "//components/captive_portal:test_support",
       "//components/dom_distiller/content/browser",
       "//components/dom_distiller/content/renderer",
       "//components/dom_distiller/core:test_support",
       "//components/guest_view/browser:test_support",
       "//components/policy:chrome_settings_proto",
       "//components/resources",
@@ skipping 29 matching lines @@
       "//third_party/webrtc_overrides",
       "//third_party/widevine/cdm:headers",
       "//ui/accessibility:test_support",
       "//ui/base:test_support",
       "//ui/compositor:test_support",
       "//ui/resources",
       "//ui/web_dialogs:test_support",
       "//v8",
     ]
 
+    if (!skip_js_tests) {
+      deps += [ "//chrome/test/data/webui:browser_tests_js_webui" ]
+    }
+
     # Runtime dependencies
     data_deps += [
       "//ppapi:ppapi_tests",
       "//ppapi:power_saver_test_plugin",
       "//remoting/webapp:browser_test_resources",
       "//remoting/webapp:unit_tests",
       "//third_party/mesa:osmesa",
       "//third_party/widevine/cdm:widevine_test_license_server",
     ]
 
@@ skipping 1861 matching lines @@
       "../browser/ui/webui/media_router/media_cast_mode_unittest.cc",
       "../browser/ui/webui/media_router/media_router_dialog_controller_impl_unittest.cc",
       "../browser/ui/webui/media_router/media_router_ui_unittest.cc",
       "../browser/ui/webui/media_router/media_router_web_ui_test.cc",
       "../browser/ui/webui/media_router/media_router_web_ui_test.h",
       "../browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc",
       "../browser/ui/webui/media_router/query_result_manager_unittest.cc",
       "../common/media_router/mojo/media_router_struct_traits_unittest.cc",
       "../utility/media_router/dial_device_description_parser_impl_unittest.cc",
     ]
-    deps += [
-      "//chrome/test/data/webui:unit_tests_js",
-      "//components/bubble:test_support",
-    ]
+    deps += [ "//components/bubble:test_support" ]
+
+    if (!skip_js_tests) {
+      deps += [ "//chrome/test/data/webui:unit_tests_js" ]
+    }
+
     data += [
       "$root_out_dir/test_data/chrome/browser/resources/print_preview/",
       "$root_out_dir/test_data/chrome/renderer/resources/extensions/",
       "$root_out_dir/test_data/ui/webui/",
     ]
   }
 
   if (is_desktop_linux && enable_native_notifications) {
     sources += [ "../browser/notifications/notification_platform_bridge_linux_unittest.cc" ]
   }
@@ skipping 1362 matching lines @@
 }
 
 if (is_win) {
   loadable_module("conflicts_dll") {
     testonly = true
     sources = [
       "conflicts/conflicts_dll.cc",
     ]
   }
 }