Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 2760693002: WebUI: Disable all JS tests in MSAN, ASAN, and TSAN bots. (Closed)

Created:
3 years, 9 months ago by dpapad
Modified:
3 years, 9 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg, stevenjb
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

WebUI: Disable all JS tests in MSAN, ASAN, and TSAN bots. There is not a lot of benefit of running WebUI JS tests on *SAN bots. Previously at crrev.com/2690303003, all MD Settings tests were disabled for ASAN bots. This CL does the same for MSAN, TSAN and for all WebUI tests. BUG=None Review-Url: https://codereview.chromium.org/2760693002 Cr-Commit-Position: refs/heads/master@{#458479} Committed: https://chromium.googlesource.com/chromium/src/+/225850541ea9b36ecb151863f54c3a4265af085f

Patch Set 1 #

Patch Set 2 : Update more #

Patch Set 3 : more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -194 lines) Patch
M chrome/test/BUILD.gn View 1 2 9 chunks +170 lines, -166 lines 0 comments Download
M chrome/test/data/webui/md_history/md_history_browsertest.js View 1 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/test/data/webui/sandboxstatus_browsertest.js View 1 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/test/data/webui/settings/advanced_page_browsertest.js View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/test/data/webui/settings/basic_page_browsertest.js View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/test/data/webui/settings/easy_unlock_browsertest_chromeos.js View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/test/data/webui/settings/languages_page_browsertest.js View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/test/data/webui/settings/settings_ui_browsertest.js View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 29 (21 generated)
dpapad
3 years, 9 months ago (2017-03-18 00:51:07 UTC) #15
dpapad
On 2017/03/18 at 00:51:07, dpapad wrote: > Friendly ping.
3 years, 9 months ago (2017-03-20 23:45:32 UTC) #19
Dan Beam
lgtm let's give it a shot!
3 years, 9 months ago (2017-03-21 03:35:52 UTC) #20
Dan Beam
i would say maybe "there's not a lot of benefit from running JavaScript tests in ...
3 years, 9 months ago (2017-03-21 03:36:29 UTC) #21
dpapad
On 2017/03/21 at 03:36:29, dbeam wrote: > i would say maybe "there's not a lot ...
3 years, 9 months ago (2017-03-21 05:37:28 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2760693002/80001
3 years, 9 months ago (2017-03-21 17:06:43 UTC) #25
commit-bot: I haz the power
Committed patchset #3 (id:80001) as https://chromium.googlesource.com/chromium/src/+/225850541ea9b36ecb151863f54c3a4265af085f
3 years, 9 months ago (2017-03-21 18:25:53 UTC) #28
Lei Zhang
3 years, 9 months ago (2017-03-22 00:19:02 UTC) #29
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:80001) has been created in
https://codereview.chromium.org/2771443002/ by thestig@chromium.org.

The reason for reverting is: May be causing isolate_tests failures.

Speculative revert for https://crbug.com/703830.

Powered by Google App Engine
This is Rietveld 408576698