Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2865023003:
Warn web developers that card networks as method names are deprecated. (Closed)
|
Created:
3 years, 7 months ago by please use gerrit instead Modified:
3 years, 7 months ago Reviewers:
Rick Byers CC:
chromium-reviews, blink-reviews, gogerald+paymentswatch_chromium.org, haraken, rouslan+payments_chromium.org, mahmadi+paymentswatch_chromium.org, sebsg+paymentswatch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionWarn web developers that card networks as method names are deprecated.
Web developers should use 'basic-card' instead. Deprecated:
new PaymentRequest(
[{
supportedMethods: ['visa', 'amex'],
}],
cart);
Should be used:
new PaymentRequest(
[{
supportedMethods: ['basic-card'],
data: {supportedNetworks: ['visa', 'amex']},
}],
cart);
Console warning message:
[Deprecation] Card issuer network ("amex", "diners", "discover",
"jcb", "mastercard", "mir", "unionpay", "visa") as payment method is
deprecated and will be removed in M64, around January 2018. Please use
payment method name "basic-card" with issuer network in the
"supportedNetworks" field instead. See
https://www.chromestatus.com/features/5725727580225536 for more
details.
Intent to deprecate thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/1udpnrlQK4Q/ot_E-htQAQAJ
BUG=719526
Review-Url: https://codereview.chromium.org/2865023003
Cr-Commit-Position: refs/heads/master@{#473997}
Committed: https://chromium.googlesource.com/chromium/src/+/9e5c20b710a753c0992126b1176015849400ca31
Patch Set 1 #
Total comments: 4
Patch Set 2 : Deprecation infrastructure #Patch Set 3 : Rebase #
Messages
Total messages: 20 (12 generated)
The CQ bit was checked by rouslan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
rouslan@chromium.org changed reviewers: + rbyers@chromium.org
Rick, ptal. Is there a process to follow here? Perhaps an "intent to deprecate" is in order.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
Shoot, looks like I missed this e-mail - sorry. Do you have a timeframe for when you believe you can remove support completely? I think we would want an "intent to deprecate and remove" thread for this since 1) deprecation messages always run a risk of contributing to warning blindness 2) that process kicks off a bunch of additional developer communications (like an entry in the deprecations blog post.
On 2017/05/16 13:46:24, Rick Byers wrote: > Shoot, looks like I missed this e-mail - sorry. Do you have a timeframe for > when you believe you can remove support completely? I had 6 months to a year in mind. > I think we would want an > "intent to deprecate and remove" thread for this since 1) deprecation messages > always run a risk of contributing to warning blindness 2) that process kicks off > a bunch of additional developer communications (like an entry in the > deprecations blog post. Will send out.
https://codereview.chromium.org/2865023003/diff/1/third_party/WebKit/Source/m... File third_party/WebKit/Source/modules/payments/PaymentRequest.cpp (right): https://codereview.chromium.org/2865023003/diff/1/third_party/WebKit/Source/m... third_party/WebKit/Source/modules/payments/PaymentRequest.cpp:409: kJSMessageSource, kWarningMessageLevel, Please use the "DeprecationMessageSource" - that'll get picked up eg. by lighthouse. Can you use the common deprecation infrastructure in Deprecation.cpp instead of rolling it yourself? https://codereview.chromium.org/2865023003/diff/1/third_party/WebKit/Source/m... third_party/WebKit/Source/modules/payments/PaymentRequest.cpp:412: "'basic-card' instead.")); In general we prefer to give developers a concrete planned removal milestone and chromestatus.com link for more context.
Description was changed from
==========
Warn web developers that card types as method names are deprecated.
Web developers should use 'basic-card' instead. Deprecated:
new PaymentRequest(
[{
supportedMethods: ['visa', 'amex'],
}],
cart);
Should be used:
new PaymentRequest(
[{
supportedMethods: ['basic-card'],
data: {supportedNetworks: ['visa', 'amex']},
}],
cart);
Spec:
https://w3c.github.io/webpayments-methods-card/
BUG=719526
==========
to
==========
Warn web developers that card types as method names are deprecated.
Web developers should use 'basic-card' instead. Deprecated:
new PaymentRequest(
[{
supportedMethods: ['visa', 'amex'],
}],
cart);
Should be used:
new PaymentRequest(
[{
supportedMethods: ['basic-card'],
data: {supportedNetworks: ['visa', 'amex']},
}],
cart);
Console warning message:
Spec:
https://w3c.github.io/webpayments-methods-card/
Intent to deprecate thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/1udpnrlQK4Q/ot_E-htQ...
BUG=719526
==========
Description was changed from
==========
Warn web developers that card types as method names are deprecated.
Web developers should use 'basic-card' instead. Deprecated:
new PaymentRequest(
[{
supportedMethods: ['visa', 'amex'],
}],
cart);
Should be used:
new PaymentRequest(
[{
supportedMethods: ['basic-card'],
data: {supportedNetworks: ['visa', 'amex']},
}],
cart);
Console warning message:
Spec:
https://w3c.github.io/webpayments-methods-card/
Intent to deprecate thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/1udpnrlQK4Q/ot_E-htQ...
BUG=719526
==========
to
==========
Warn web developers that card types as method names are deprecated.
Web developers should use 'basic-card' instead. Deprecated:
new PaymentRequest(
[{
supportedMethods: ['visa', 'amex'],
}],
cart);
Should be used:
new PaymentRequest(
[{
supportedMethods: ['basic-card'],
data: {supportedNetworks: ['visa', 'amex']},
}],
cart);
Console warning message:
[Deprecation] Card issuer network ("amex", "diners", "discover",
"jcb", "mastercard", "mir", "unionpay", "visa") as payment method is
deprecated and will be removed in M64, around January 2018. Please use
payment method name "basic-card" with issuer network in the
"supportedNetworks" field instead. See
https://www.chromestatus.com/features/5725727580225536 for more
details.
Intent to deprecate thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/1udpnrlQK4Q/ot_E-htQ...
BUG=719526
==========
Rick, ptal patch 2. https://codereview.chromium.org/2865023003/diff/1/third_party/WebKit/Source/m... File third_party/WebKit/Source/modules/payments/PaymentRequest.cpp (right): https://codereview.chromium.org/2865023003/diff/1/third_party/WebKit/Source/m... third_party/WebKit/Source/modules/payments/PaymentRequest.cpp:409: kJSMessageSource, kWarningMessageLevel, On 2017/05/16 13:48:58, Rick Byers wrote: > Please use the "DeprecationMessageSource" - that'll get picked up eg. by > lighthouse. Can you use the common deprecation infrastructure in > Deprecation.cpp instead of rolling it yourself? Done. https://codereview.chromium.org/2865023003/diff/1/third_party/WebKit/Source/m... third_party/WebKit/Source/modules/payments/PaymentRequest.cpp:412: "'basic-card' instead.")); On 2017/05/16 13:48:58, Rick Byers wrote: > In general we prefer to give developers a concrete planned removal milestone and > http://chromestatus.com link for more context. Done.
Description was changed from
==========
Warn web developers that card types as method names are deprecated.
Web developers should use 'basic-card' instead. Deprecated:
new PaymentRequest(
[{
supportedMethods: ['visa', 'amex'],
}],
cart);
Should be used:
new PaymentRequest(
[{
supportedMethods: ['basic-card'],
data: {supportedNetworks: ['visa', 'amex']},
}],
cart);
Console warning message:
[Deprecation] Card issuer network ("amex", "diners", "discover",
"jcb", "mastercard", "mir", "unionpay", "visa") as payment method is
deprecated and will be removed in M64, around January 2018. Please use
payment method name "basic-card" with issuer network in the
"supportedNetworks" field instead. See
https://www.chromestatus.com/features/5725727580225536 for more
details.
Intent to deprecate thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/1udpnrlQK4Q/ot_E-htQ...
BUG=719526
==========
to
==========
Warn web developers that card networks as method names are deprecated.
Web developers should use 'basic-card' instead. Deprecated:
new PaymentRequest(
[{
supportedMethods: ['visa', 'amex'],
}],
cart);
Should be used:
new PaymentRequest(
[{
supportedMethods: ['basic-card'],
data: {supportedNetworks: ['visa', 'amex']},
}],
cart);
Console warning message:
[Deprecation] Card issuer network ("amex", "diners", "discover",
"jcb", "mastercard", "mir", "unionpay", "visa") as payment method is
deprecated and will be removed in M64, around January 2018. Please use
payment method name "basic-card" with issuer network in the
"supportedNetworks" field instead. See
https://www.chromestatus.com/features/5725727580225536 for more
details.
Intent to deprecate thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/1udpnrlQK4Q/ot_E-htQ...
BUG=719526
==========
LGTM, thanks!
The CQ bit was checked by rouslan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rbyers@chromium.org Link to the patchset: https://codereview.chromium.org/2865023003/#ps40001 (title: "Rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495555952616660,
"parent_rev": "884608358e1fd3064ad56cba1d39049e4f130943", "commit_rev":
"9e5c20b710a753c0992126b1176015849400ca31"}
Message was sent while issue was closed.
Description was changed from
==========
Warn web developers that card networks as method names are deprecated.
Web developers should use 'basic-card' instead. Deprecated:
new PaymentRequest(
[{
supportedMethods: ['visa', 'amex'],
}],
cart);
Should be used:
new PaymentRequest(
[{
supportedMethods: ['basic-card'],
data: {supportedNetworks: ['visa', 'amex']},
}],
cart);
Console warning message:
[Deprecation] Card issuer network ("amex", "diners", "discover",
"jcb", "mastercard", "mir", "unionpay", "visa") as payment method is
deprecated and will be removed in M64, around January 2018. Please use
payment method name "basic-card" with issuer network in the
"supportedNetworks" field instead. See
https://www.chromestatus.com/features/5725727580225536 for more
details.
Intent to deprecate thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/1udpnrlQK4Q/ot_E-htQ...
BUG=719526
==========
to
==========
Warn web developers that card networks as method names are deprecated.
Web developers should use 'basic-card' instead. Deprecated:
new PaymentRequest(
[{
supportedMethods: ['visa', 'amex'],
}],
cart);
Should be used:
new PaymentRequest(
[{
supportedMethods: ['basic-card'],
data: {supportedNetworks: ['visa', 'amex']},
}],
cart);
Console warning message:
[Deprecation] Card issuer network ("amex", "diners", "discover",
"jcb", "mastercard", "mir", "unionpay", "visa") as payment method is
deprecated and will be removed in M64, around January 2018. Please use
payment method name "basic-card" with issuer network in the
"supportedNetworks" field instead. See
https://www.chromestatus.com/features/5725727580225536 for more
details.
Intent to deprecate thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/1udpnrlQK4Q/ot_E-htQ...
BUG=719526
Review-Url: https://codereview.chromium.org/2865023003
Cr-Commit-Position: refs/heads/master@{#473997}
Committed:
https://chromium.googlesource.com/chromium/src/+/9e5c20b710a753c0992126b11760...
==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/9e5c20b710a753c0992126b11760... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
