Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2664)

Unified Diff: third_party/WebKit/Source/core/frame/Deprecation.cpp

Issue 2865023003: Warn web developers that card networks as method names are deprecated. (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/payments/PaymentRequest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/Deprecation.cpp
diff --git a/third_party/WebKit/Source/core/frame/Deprecation.cpp b/third_party/WebKit/Source/core/frame/Deprecation.cpp
index 0499bd8a40f5638ac11bcea5e7f31fe8159c0fa7..4ec81a37ce822308b14ecad188d1a6a0d56ba741 100644
--- a/third_party/WebKit/Source/core/frame/Deprecation.cpp
+++ b/third_party/WebKit/Source/core/frame/Deprecation.cpp
@@ -19,6 +19,8 @@ enum Milestone {
M60,
M61,
M62,
+ M63,
+ M64,
};
const char* milestoneString(Milestone milestone) {
@@ -34,6 +36,10 @@ const char* milestoneString(Milestone milestone) {
return "M61, around September 2017";
case M62:
return "M62, around October 2017";
+ case M63:
+ return "M63, around December 2017";
+ case M64:
+ return "M64, around January 2018";
}
NOTREACHED();
@@ -425,6 +431,14 @@ String Deprecation::DeprecationMessage(UseCounter::Feature feature) {
"recent-changes-credential-management-api for migration suggestions.",
milestoneString(M62));
+ case UseCounter::kPaymentRequestNetworkNameInSupportedMethods:
+ return replacedWillBeRemoved(
+ "Card issuer network (\"amex\", \"diners\", \"discover\", \"jcb\", "
+ "\"mastercard\", \"mir\", \"unionpay\", \"visa\") as payment method",
+ "payment method name \"basic-card\" with issuer network in the "
+ "\"supportedNetworks\" field",
+ M64, "5725727580225536");
+
// Features that aren't deprecated don't have a deprecation message.
default:
return String();
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/payments/PaymentRequest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698