Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: third_party/WebKit/Source/core/frame/Deprecation.cpp

Issue 2865023003: Warn web developers that card networks as method names are deprecated. (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/payments/PaymentRequest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/frame/Deprecation.h" 5 #include "core/frame/Deprecation.h"
6 6
7 #include "core/dom/Document.h" 7 #include "core/dom/Document.h"
8 #include "core/dom/ExecutionContext.h" 8 #include "core/dom/ExecutionContext.h"
9 #include "core/frame/FrameConsole.h" 9 #include "core/frame/FrameConsole.h"
10 #include "core/frame/LocalFrame.h" 10 #include "core/frame/LocalFrame.h"
11 #include "core/inspector/ConsoleMessage.h" 11 #include "core/inspector/ConsoleMessage.h"
12 #include "core/page/Page.h" 12 #include "core/page/Page.h"
13 #include "core/workers/WorkerOrWorkletGlobalScope.h" 13 #include "core/workers/WorkerOrWorkletGlobalScope.h"
14 14
15 namespace { 15 namespace {
16 16
17 enum Milestone { 17 enum Milestone {
18 M59, 18 M59,
19 M60, 19 M60,
20 M61, 20 M61,
21 M62, 21 M62,
22 M63,
23 M64,
22 }; 24 };
23 25
24 const char* milestoneString(Milestone milestone) { 26 const char* milestoneString(Milestone milestone) {
25 // These are the Estimated Stable Dates: 27 // These are the Estimated Stable Dates:
26 // https://www.chromium.org/developers/calendar 28 // https://www.chromium.org/developers/calendar
27 29
28 switch (milestone) { 30 switch (milestone) {
29 case M59: 31 case M59:
30 return "M59, around June 2017"; 32 return "M59, around June 2017";
31 case M60: 33 case M60:
32 return "M60, around August 2017"; 34 return "M60, around August 2017";
33 case M61: 35 case M61:
34 return "M61, around September 2017"; 36 return "M61, around September 2017";
35 case M62: 37 case M62:
36 return "M62, around October 2017"; 38 return "M62, around October 2017";
39 case M63:
40 return "M63, around December 2017";
41 case M64:
42 return "M64, around January 2018";
37 } 43 }
38 44
39 NOTREACHED(); 45 NOTREACHED();
40 return nullptr; 46 return nullptr;
41 } 47 }
42 48
43 String replacedBy(const char* feature, const char* replacement) { 49 String replacedBy(const char* feature, const char* replacement) {
44 return String::Format("%s is deprecated. Please use %s instead.", feature, 50 return String::Format("%s is deprecated. Please use %s instead.", feature,
45 replacement); 51 replacement);
46 } 52 }
(...skipping 371 matching lines...) Expand 10 before | Expand all | Expand 10 after
418 case UseCounter::kCredentialManagerAdditionalData: 424 case UseCounter::kCredentialManagerAdditionalData:
419 case UseCounter::kCredentialManagerCustomFetch: 425 case UseCounter::kCredentialManagerCustomFetch:
420 return String::Format( 426 return String::Format(
421 "Passing 'PasswordCredential' objects into 'fetch(..., { " 427 "Passing 'PasswordCredential' objects into 'fetch(..., { "
422 "credentials: ... })' is deprecated, and will be removed in %s. See " 428 "credentials: ... })' is deprecated, and will be removed in %s. See "
423 "https://www.chromestatus.com/features/5689327799500800 for more " 429 "https://www.chromestatus.com/features/5689327799500800 for more "
424 "details and https://www.chromium.org/developers/" 430 "details and https://www.chromium.org/developers/"
425 "recent-changes-credential-management-api for migration suggestions.", 431 "recent-changes-credential-management-api for migration suggestions.",
426 milestoneString(M62)); 432 milestoneString(M62));
427 433
434 case UseCounter::kPaymentRequestNetworkNameInSupportedMethods:
435 return replacedWillBeRemoved(
436 "Card issuer network (\"amex\", \"diners\", \"discover\", \"jcb\", "
437 "\"mastercard\", \"mir\", \"unionpay\", \"visa\") as payment method",
438 "payment method name \"basic-card\" with issuer network in the "
439 "\"supportedNetworks\" field",
440 M64, "5725727580225536");
441
428 // Features that aren't deprecated don't have a deprecation message. 442 // Features that aren't deprecated don't have a deprecation message.
429 default: 443 default:
430 return String(); 444 return String();
431 } 445 }
432 } 446 }
433 447
434 } // namespace blink 448 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/payments/PaymentRequest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698