Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2864693002: (Reland x3) Expose resources in Robolectric/JUnit tests. (Closed)

Created:
3 years, 7 months ago by mikecase (-- gone --)
Modified:
3 years, 7 months ago
Reviewers:
nyquist, jbudorick
CC:
agrieve+watch_chromium.org, chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

(Reland x3) Expose resources in Robolectric/JUnit tests. Will let people use Android resources in Robolectric tests. To use, specify package_name GN variable in junit_binary targets with your apps package name. This change will also (basically) require that you use the generated wrappers from out_dir/bin/run_<suite name> to run the tests since GN will be generating many arguments to pass along to the test runner. BUG=693573 Review-Url: https://codereview.chromium.org/2864693002 Cr-Commit-Position: refs/heads/master@{#471523} Committed: https://chromium.googlesource.com/chromium/src/+/0b6b35f669cfd191e369832a9385d939650c244b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -92 lines) Patch
M build/android/gyp/create_test_runner_script.py View 3 chunks +16 lines, -0 lines 0 comments Download
M build/android/gyp/write_build_config.py View 2 chunks +3 lines, -1 line 0 comments Download
M build/android/pylib/junit/junit_test_instance.py View 3 chunks +20 lines, -0 lines 0 comments Download
M build/android/pylib/local/machine/local_machine_junit_test_run.py View 4 chunks +47 lines, -16 lines 0 comments Download
M build/android/test_runner.py View 1 chunk +15 lines, -0 lines 0 comments Download
M build/config/android/internal_rules.gni View 2 chunks +31 lines, -2 lines 0 comments Download
M build/config/android/rules.gni View 2 chunks +16 lines, -0 lines 0 comments Download
M chrome/android/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/suggestions/TileGroupTest.java View 5 chunks +1 line, -56 lines 0 comments Download
M testing/android/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M testing/android/junit/java/src/org/chromium/testing/local/GNManifestFactory.java View 1 chunk +40 lines, -11 lines 0 comments Download
M testing/android/junit/java/src/org/chromium/testing/local/LocalRobolectricTestRunner.java View 2 chunks +5 lines, -1 line 0 comments Download
M third_party/robolectric/README.chromium View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
mikecase (-- gone --)
So second attempt to land failed (similiar to first attempt) b/c "Android Tests" bot did ...
3 years, 7 months ago (2017-05-05 18:33:56 UTC) #2
mikecase (-- gone --)
friendly ping
3 years, 7 months ago (2017-05-12 15:50:16 UTC) #7
jbudorick
On 2017/05/12 15:50:16, mikecase wrote: > friendly ping No changes to this CL, just https://codereview.chromium.org/2862603002 ...
3 years, 7 months ago (2017-05-12 15:51:23 UTC) #8
mikecase (-- gone --)
On 2017/05/12 at 15:51:23, jbudorick wrote: > On 2017/05/12 15:50:16, mikecase wrote: > > friendly ...
3 years, 7 months ago (2017-05-12 16:29:51 UTC) #9
jbudorick
On 2017/05/12 16:29:51, mikecase wrote: > On 2017/05/12 at 15:51:23, jbudorick wrote: > > On ...
3 years, 7 months ago (2017-05-12 16:32:13 UTC) #10
nyquist
lgtm
3 years, 7 months ago (2017-05-12 23:23:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864693002/1
3 years, 7 months ago (2017-05-12 23:41:21 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-13 01:13:23 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0b6b35f669cfd191e369832a9385...

Powered by Google App Engine
This is Rietveld 408576698