Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2862603002: Move Android resource_zip files into own build subdir. (Closed)

Created:
3 years, 7 months ago by mikecase (-- gone --)
Modified:
3 years, 7 months ago
Reviewers:
jbudorick, agrieve
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move Android resource_zip files into own build subdir. Want to move resources.zip files out of gen/ directory since they won't get packaged by several of the Builder bots. We will need these resources.zip files for JUnit tests. BUG=693573 Review-Url: https://codereview.chromium.org/2862603002 Cr-Commit-Position: refs/heads/master@{#469191} Committed: https://chromium.googlesource.com/chromium/src/+/54c8a0f1de1a3cf8599dde9efb7bc61f08fef03f

Patch Set 1 #

Patch Set 2 : Move Android resource_zip files into own build subdir. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -33 lines) Patch
M build/android/lint/suppressions.xml View 1 5 chunks +28 lines, -28 lines 0 comments Download
M build/config/android/rules.gni View 6 chunks +26 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
mikecase (-- gone --)
BEFORE: /src/out/Res/gen/chrome/android/chrome_java_resources.resources.zip AFTER: /src/out/Res/resource_zips/chrome/android/chrome_java_resources.resources.zip what do you think?
3 years, 7 months ago (2017-05-03 17:28:05 UTC) #2
jbudorick
This looks ok. Kind of annoying that we have to repeat the same logic over ...
3 years, 7 months ago (2017-05-03 17:37:07 UTC) #4
agrieve
yeah, pretty annoying, but I have no better ideas. lgtm
3 years, 7 months ago (2017-05-03 18:13:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2862603002/1
3 years, 7 months ago (2017-05-03 18:17:29 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/285012)
3 years, 7 months ago (2017-05-03 18:47:32 UTC) #9
mikecase (-- gone --)
Needed to grab suppressions.xml from my other CL, https://codereview.chromium.org/2842603002
3 years, 7 months ago (2017-05-03 22:10:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2862603002/20001
3 years, 7 months ago (2017-05-03 22:10:41 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 23:19:09 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/54c8a0f1de1a3cf8599dde9efb7b...

Powered by Google App Engine
This is Rietveld 408576698