(Reland x2) Expose resources in Robolectric/JUnit tests.

(Reland x2) Expose resources in Robolectric/JUnit tests.

Will let people use Android resources in Robolectric tests.
To use, specify package_name GN variable in junit_binary
targets with your apps package name.

This change will also (basically) require that you use the
generated wrappers from out_dir/bin/run_<suite name> to run
the tests since GN will be generating many arguments to
pass along to the test runner.

BUG=693573
Review-Url: https://codereview.chromium.org/2842603002
Cr-Commit-Position: refs/heads/master@{#468822}
Committed: https://chromium.googlesource.com/chromium/src/+/bc26a6f5b4ed9ee2b84878c17e8f4149db815db7

[mikecase (-- gone --), 2017-04-24 22:54:42]

Description was changed from

==========
(Reland x2) Expose resources in Robolectric/JUnit tests.

BUG=693573
==========

to

==========
(Reland x2) Expose resources in Robolectric/JUnit tests.

Will let people use Android resources in Robolectric tests.
To use, specify package_name GN variable in junit_binary
targets with your apps package name.

This change will also (basically) require that you use the
generated wrappers from out_dir/bin/run_<suite name> to run
the tests since GN will be generating many arguments to
pass along to the test runner.

BUG=693573
==========

[mikecase (-- gone --), 2017-04-24 22:59:08]

mikecase@chromium.org changed reviewers:
+ agrieve@chromium.org, jbudorick@chromium.org

[mikecase (-- gone --), 2017-04-24 22:59:09]

So, want to try landing again. Issue last time was apparently <out_dir>/gen
folder is excluded when some bots archive builds. This was a bummer since the
resources.zip files that junit tests used live there. The resources.zip files
could not be found, and the tests failed.

The only changes (since last land attempt) are in rules.gni where I switch where
all the resources.zip files live. And have to update the
b/a/lint/suppresions.xml accordingly

Original CL: https://codereview.chromium.org/2819983002

[mikecase (-- gone --), 2017-04-24 23:01:02]

mikecase@chromium.org changed reviewers:
+ nyquist@chromium.org

[agrieve, 2017-04-25 02:00:19]

On 2017/04/24 23:01:02, mikecase wrote:

lgtm, but please add a comment to each relevant line saying why the .zip is
using root_out_dir rather than root_gen_dir.

[mikecase (-- gone --), 2017-04-26 16:56:40]

On 2017/04/25 at 02:00:19, agrieve wrote:
> On 2017/04/24 23:01:02, mikecase wrote:
> 
> lgtm, but please add a comment to each relevant line saying why the .zip is
using root_out_dir rather than root_gen_dir.

Done. Added comments explaining why not using root_gen_dir

[nyquist, 2017-04-26 21:33:52]

lgtm for my parts

[mikecase (-- gone --), 2017-04-26 22:54:43]

The CQ bit was checked by mikecase@chromium.org

[mikecase (-- gone --), 2017-04-26 22:54:44]

The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2842603002/#ps40001
(title: "GN generate resource dirs.")

[commit-bot: I haz the power, 2017-04-26 22:55:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbudorick, 2017-04-26 22:55:48]

lgtm

[commit-bot: I haz the power, 2017-04-26 23:00:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 23:00:34]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[mikecase (-- gone --), 2017-05-02 21:07:38]

The CQ bit was checked by mikecase@chromium.org

[mikecase (-- gone --), 2017-05-02 21:07:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
nyquist@chromium.org, jbudorick@chromium.org, agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2842603002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-02 21:08:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 22:14:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 22:14:22]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[mikecase (-- gone --), 2017-05-02 22:45:52]

The CQ bit was checked by mikecase@chromium.org

[commit-bot: I haz the power, 2017-05-02 22:46:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 23:47:42]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493765152835910,
"parent_rev": "103954da11bdf022c300c4620d39b3b38ef15baa", "commit_rev":
"bc26a6f5b4ed9ee2b84878c17e8f4149db815db7"}

[commit-bot: I haz the power, 2017-05-02 23:47:56]

Description was changed from

==========
(Reland x2) Expose resources in Robolectric/JUnit tests.

Will let people use Android resources in Robolectric tests.
To use, specify package_name GN variable in junit_binary
targets with your apps package name.

This change will also (basically) require that you use the
generated wrappers from out_dir/bin/run_<suite name> to run
the tests since GN will be generating many arguments to
pass along to the test runner.

BUG=693573
==========

to

==========
(Reland x2) Expose resources in Robolectric/JUnit tests.

Will let people use Android resources in Robolectric tests.
To use, specify package_name GN variable in junit_binary
targets with your apps package name.

This change will also (basically) require that you use the
generated wrappers from out_dir/bin/run_<suite name> to run
the tests since GN will be generating many arguments to
pass along to the test runner.

BUG=693573

Review-Url: https://codereview.chromium.org/2842603002
Cr-Commit-Position: refs/heads/master@{#468822}
Committed:
https://chromium.googlesource.com/chromium/src/+/bc26a6f5b4ed9ee2b84878c17e8f...
==========

[commit-bot: I haz the power, 2017-05-02 23:47:57]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/bc26a6f5b4ed9ee2b84878c17e8f...

[aelias_OOO_until_Jul13, 2017-05-03 02:00:57]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2859583004/ by aelias@chromium.org.

The reason for reverting is: TileGroupTest failing on waterfall, see
http://crbug.com/717820

BUG=717820.

[mikecase (-- gone --), 2017-05-03 16:45:02]

looked into this. big oversite by me. the OUTDIR/obj/ directory is also excluded
when packaging builds on Android Builder (similiar to OUTDIR/gen/). I got
tricked from the fact OUTDIR/<somesubdir>/obj/ occurs in lots of places which do
get packaged.

I have no clue where I should/can put these resource_zips? I guess maybe in
gen.runtime/ directory which definitely DOES get packaged up by the Android
Builder

sry for second breakage.