MD Settings: Fix dragging slider bugging out the Enter key.

MD Settings: Fix dragging slider bugging out the Enter key.

There's a bug in the Polymer gesture code that prevents "keydown" to be
recognized after the "track" (unless "mousedown" happens and resets the
prevention state).

Manually calling Gesture's reset function will fix the issue. This should be
considered a temporary fix until Polymer fixes the gesture code.

BUG=706709
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2864563002
Cr-Commit-Position: refs/heads/master@{#476151}
Committed: https://chromium.googlesource.com/chromium/src/+/ea73b1f7ddc1a243ad5886a2aa909f91eb492974

[scottchen, 2017-05-04 23:02:07]

Description was changed from

==========
MD Settings: Fix dragging slider bugging out the Enter key.

BUG=706709
==========

to

==========
MD Settings: Fix dragging slider bugging out the Enter key.

BUG=706709
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[scottchen, 2017-05-04 23:04:05]

scottchen@chromium.org changed reviewers:
+ dschuyler@chromium.org

[scottchen, 2017-05-04 23:04:06]

There's a bug in the Polymer gesture code that prevents "keydown" to be
recognized after the "track" (unless "mousedown" happens and resets the
prevention state).

Manually calling Gesture's reset function will fix the issue. This should be
considered a temporary fix until Polymer fixes the gesture code.

[scottchen, 2017-05-04 23:04:22]

Description was changed from

==========
MD Settings: Fix dragging slider bugging out the Enter key.

BUG=706709
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix dragging slider bugging out the Enter key.

There's a bug in the Polymer gesture code that prevents "keydown" to be
recognized after the "track" (unless "mousedown" happens and resets the
prevention state).

Manually calling Gesture's reset function will fix the issue. This should be
considered a temporary fix until Polymer fixes the gesture code.

BUG=706709
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[scottchen, 2017-05-04 23:16:35]

scottchen@chromium.org changed reviewers:
+ dbeam@chromium.org

[scottchen, 2017-05-04 23:16:36]

+dbeam@ since we were talking about this offline

[Dan Beam, 2017-05-04 23:36:23]

does it make sense to let the event loop turn or something before resetting? 
i.e. setTimeout(, 1) or anything?

I'm worried about synchronously triggered, synthetic events like 'tap' or
'click' happening before 'up' (which the original code is trying to prevent,
afaik)

[scottchen, 2017-05-04 23:48:10]

On 2017/05/04 23:36:23, Dan Beam wrote:
> does it make sense to let the event loop turn or something before resetting? 
> i.e. setTimeout(, 1) or anything?
> 
> I'm worried about synchronously triggered, synthetic events like 'tap' or
> 'click' happening before 'up' (which the original code is trying to prevent,
> afaik)

I tried: drag -> move mouse over some button -> let go, and it doesn't trigger
tap on that other button, so it should be fine. 
If we're still worried about it, we could wrap it in setTimeout or just have
this trigger by settingsSlider.onblur & settingsToggleButton.onblur.

[Dan Beam, 2017-05-05 00:02:23]

lgtm

[scottchen, 2017-05-05 00:07:00]

The CQ bit was checked by scottchen@chromium.org

[commit-bot: I haz the power, 2017-05-05 00:07:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 00:27:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 00:27:09]

Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[dschuyler, 2017-05-05 18:17:19]

rs lgtm

[scottchen, 2017-05-23 21:10:00]

On 2017/05/05 18:17:19, dschuyler wrote:
> rs lgtm

Just FYI, currently working with dpapad@ to get the necessary stuff in closure
compiler externs before this can land.

[scottchen, 2017-06-01 00:22:13]

The CQ bit was checked by scottchen@chromium.org

[commit-bot: I haz the power, 2017-06-01 00:23:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 02:07:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496276533746020,
"parent_rev": "971cd4520e7ab8c78c9e1b1ccc0c916a936b0378", "commit_rev":
"ea73b1f7ddc1a243ad5886a2aa909f91eb492974"}

[commit-bot: I haz the power, 2017-06-01 02:07:14]

Description was changed from

==========
MD Settings: Fix dragging slider bugging out the Enter key.

There's a bug in the Polymer gesture code that prevents "keydown" to be
recognized after the "track" (unless "mousedown" happens and resets the
prevention state).

Manually calling Gesture's reset function will fix the issue. This should be
considered a temporary fix until Polymer fixes the gesture code.

BUG=706709
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix dragging slider bugging out the Enter key.

There's a bug in the Polymer gesture code that prevents "keydown" to be
recognized after the "track" (unless "mousedown" happens and resets the
prevention state).

Manually calling Gesture's reset function will fix the issue. This should be
considered a temporary fix until Polymer fixes the gesture code.

BUG=706709
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2864563002
Cr-Commit-Position: refs/heads/master@{#476151}
Committed:
https://chromium.googlesource.com/chromium/src/+/ea73b1f7ddc1a243ad5886a2aa90...
==========

[commit-bot: I haz the power, 2017-06-01 02:07:15]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ea73b1f7ddc1a243ad5886a2aa90...