chrome/browser/resources/settings/controls/settings_slider.js - Issue 2864563002: MD Settings: Fix dragging slider bugging out the Enter key.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/controls/settings_slider.js

Issue 2864563002: MD Settings: Fix dragging slider bugging out the Enter key. (Closed)

Patch Set: also fix this for settings-toggle-button Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/settings/controls/settings_slider.js

diff --git a/chrome/browser/resources/settings/controls/settings_slider.js b/chrome/browser/resources/settings/controls/settings_slider.js

index 1d7e2a94372ca4f788a7972bb1dc37e8c08cf372..4c1c25f40944de087950cdb359dc2dd4c44f4594 100644

--- a/chrome/browser/resources/settings/controls/settings_slider.js

+++ b/chrome/browser/resources/settings/controls/settings_slider.js

@@ -136,4 +136,13 @@ Polymer({

assert(typeof closestIndex != 'undefined');

return closestIndex;

+ /**

+ * TODO(scottchen): temporary fix until polymer gesture bug resolved. See:

+ * https://github.com/PolymerElements/paper-slider/issues/186

+ * @private

+ */

+ resetTrackLock_: function() {

+ Polymer.Gestures.gestures.tap.reset();

+ },

});