chrome/browser/resources/settings/controls/settings_toggle_button.html - Issue 2864563002: MD Settings: Fix dragging slider bugging out the Enter key.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/controls/settings_toggle_button.html

Issue 2864563002: MD Settings: Fix dragging slider bugging out the Enter key. (Closed)

Patch Set: also fix this for settings-toggle-button Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/settings/controls/settings_slider.js ('k') | chrome/browser/resources/settings/controls/settings_toggle_button.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <link rel="import" href="chrome://resources/cr_elements/policy/cr_policy_pref_in dicator.html">	1 <link rel="import" href="chrome://resources/cr_elements/policy/cr_policy_pref_in dicator.html">

2 <link rel="import" href="chrome://resources/html/polymer.html">	2 <link rel="import" href="chrome://resources/html/polymer.html">

3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-toggle-button/pap er-toggle-button.html">	3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-toggle-button/pap er-toggle-button.html">

4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-f lex-layout-classes.html">	4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-f lex-layout-classes.html">

5 <link rel="import" href="settings_boolean_control_behavior.html">	5 <link rel="import" href="settings_boolean_control_behavior.html">

6 <link rel="import" href="../settings_shared_css.html">	6 <link rel="import" href="../settings_shared_css.html">

7	7

8 <dom-module id="settings-toggle-button">	8 <dom-module id="settings-toggle-button">

9 <template>	9 <template>

10 <style include="settings-shared iron-flex">	10 <style include="settings-shared iron-flex">

(...skipping 31 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
42 <div id="label" class="label">[[label]]</div>	42 <div id="label" class="label">[[label]]</div>

43 <div id="subLabel" class="secondary label">[[subLabel]]</div>	43 <div id="subLabel" class="secondary label">[[subLabel]]</div>

44 </div>	44 </div>

45 <content select=".more-actions"></content>	45 <content select=".more-actions"></content>

46 <template is="dom-if" if="[[hasPrefPolicyIndicator(pref.*)]]">	46 <template is="dom-if" if="[[hasPrefPolicyIndicator(pref.*)]]">

47 <cr-policy-pref-indicator pref="[[pref]]" icon-aria-label="[[label]]">	47 <cr-policy-pref-indicator pref="[[pref]]" icon-aria-label="[[label]]">

48 </cr-policy-pref-indicator>	48 </cr-policy-pref-indicator>

49 </template>	49 </template>

50 <paper-toggle-button id="control" checked="{{checked}}"	50 <paper-toggle-button id="control" checked="{{checked}}"

51 on-change="notifyChangedByUserInteraction" aria-labelledby="label"	51 on-change="notifyChangedByUserInteraction" aria-labelledby="label"

52 aria-describedby="subLabel"	52 aria-describedby="subLabel" on-up="resetTrackLock_"

53 disabled="[[controlDisabled_(disabled, pref)]]">	53 disabled="[[controlDisabled_(disabled, pref)]]">

54 </paper-toggle-button>	54 </paper-toggle-button>

55 </div>	55 </div>

56 </template>	56 </template>

57 <script src="settings_toggle_button.js"></script>	57 <script src="settings_toggle_button.js"></script>

58 </dom-module>	58 </dom-module>

OLD	NEW