[MD Bookmarks] Fix crash when opening a chrome-extension:// URL.

[MD Bookmarks] Fix crash when opening a chrome-extension:// URL.

This CL fixes a crash which was happening because the bookmark manager
API expects an extension to be associated with the WebUI.

BUG=713965
Review-Url: https://codereview.chromium.org/2864213002
Cr-Commit-Position: refs/heads/master@{#473518}
Committed: https://chromium.googlesource.com/chromium/src/+/862d903230e664fa75a09f6546366cb51e1e53bd

[calamity, 2017-05-08 04:38:51]

calamity@chromium.org changed reviewers:
+ benwells@chromium.org

[calamity, 2017-05-08 04:38:51]

+benwells for OWNERS.

[benwells, 2017-05-22 02:59:31]

https://codereview.chromium.org/2864213002/diff/1/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_tab_util.cc (right):

https://codereview.chromium.org/2864213002/diff/1/chrome/browser/extensions/e...
chrome/browser/extensions/extension_tab_util.cc:218: (!function->extension() ||
I would have thought (function->extension &&... would be more appropriate here.

[calamity, 2017-05-22 03:02:32]

https://codereview.chromium.org/2864213002/diff/1/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_tab_util.cc (right):

https://codereview.chromium.org/2864213002/diff/1/chrome/browser/extensions/e...
chrome/browser/extensions/extension_tab_util.cc:218: (!function->extension() ||
On 2017/05/22 02:59:31, benwells wrote:
> I would have thought (function->extension &&... would be more appropriate
here.

I think we want to hit the fallback behavior in this case, and assume that this
non-extension is not in split mode. I'm happy to defer to your judgment though.

[benwells, 2017-05-22 05:29:44]

lgtm

https://codereview.chromium.org/2864213002/diff/1/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_tab_util.cc (right):

https://codereview.chromium.org/2864213002/diff/1/chrome/browser/extensions/e...
chrome/browser/extensions/extension_tab_util.cc:218: (!function->extension() ||
On 2017/05/22 03:02:32, calamity wrote:
> On 2017/05/22 02:59:31, benwells wrote:
> > I would have thought (function->extension &&... would be more appropriate
> here.
> 
> I think we want to hit the fallback behavior in this case, and assume that
this
> non-extension is not in split mode. I'm happy to defer to your judgment
though.

OK ... so like !(function->extension() && function->extension()->IsSplitMode())

yeah that makes sense :)

[calamity, 2017-05-22 05:44:28]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2017-05-22 05:44:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 07:14:31]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495431868643280, "parent_rev":
"722473f6b681bad4dd6dd5897d281339c81efe93", "commit_rev":
"862d903230e664fa75a09f6546366cb51e1e53bd"}

[commit-bot: I haz the power, 2017-05-22 07:14:43]

Description was changed from

==========
[MD Bookmarks] Fix crash when opening a chrome-extension:// URL.

This CL fixes a crash which was happening because the bookmark manager
API expects an extension to be associated with the WebUI.

BUG=713965
==========

to

==========
[MD Bookmarks] Fix crash when opening a chrome-extension:// URL.

This CL fixes a crash which was happening because the bookmark manager
API expects an extension to be associated with the WebUI.

BUG=713965

Review-Url: https://codereview.chromium.org/2864213002
Cr-Commit-Position: refs/heads/master@{#473518}
Committed:
https://chromium.googlesource.com/chromium/src/+/862d903230e664fa75a09f654636...
==========

[commit-bot: I haz the power, 2017-05-22 07:14:44]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/862d903230e664fa75a09f654636...