[MD Bookmarks] Fix crash when opening a chrome-extension:// URL.

chrome/browser/extensions/extension_tab_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_tab_util.h"
 
 #include <stddef.h>
 
 #include "base/macros.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 197 matching lines @@
 
   // Default to not pinning the tab. Setting the 'pinned' property to true
   // will override this default.
   bool pinned = false;
   if (params.pinned.get())
     pinned = *params.pinned;
 
   // We can't load extension URLs into incognito windows unless the extension
   // uses split mode. Special case to fall back to a tabbed window.
   if (url.SchemeIs(kExtensionScheme) &&
-      !IncognitoInfo::IsSplitMode(function->extension()) &&
+      (!function->extension() ||

[benwells, 2017/05/22 02:59:31]

I would have thought (function->extension &&... would be more appropriate here.

[calamity, 2017/05/22 03:02:32]

I think we want to hit the fallback behavior in this case, and assume that this
non-extension is not in split mode. I'm happy to defer to your judgment though.

[benwells, 2017/05/22 05:29:43]

OK ... so like !(function->extension() && function->extension()->IsSplitMode())

yeah that makes sense :)

+       !IncognitoInfo::IsSplitMode(function->extension())) &&
       browser->profile()->IsOffTheRecord()) {
     Profile* profile = browser->profile()->GetOriginalProfile();
 
     browser = chrome::FindTabbedBrowser(profile, false);
     if (!browser) {
       Browser::CreateParams params =
           Browser::CreateParams(Browser::TYPE_TABBED, profile, user_gesture);
       browser = new Browser(params);
       browser->window()->Show();
     }
@@ skipping 486 matching lines @@
   chrome::ShowSingletonTabOverwritingNTP(browser, params);
   return true;
 }
 
 // static
 bool ExtensionTabUtil::BrowserSupportsTabs(Browser* browser) {
   return browser && browser->tab_strip_model() && !browser->is_devtools();
 }
 
 }  // namespace extensions