[MD Bookmarks] Fix crash when opening a chrome-extension:// URL.

chrome/browser/extensions/extension_tab_util.cc

Index: chrome/browser/extensions/extension_tab_util.cc
diff --git a/chrome/browser/extensions/extension_tab_util.cc b/chrome/browser/extensions/extension_tab_util.cc
index ffaad663823c3a21a005a7035048a64def64531b..2d4a5817fbe94c77282359d1f50cfd6c8280c2a8 100644
--- a/chrome/browser/extensions/extension_tab_util.cc
+++ b/chrome/browser/extensions/extension_tab_util.cc
@@ -215,7 +215,8 @@ base::DictionaryValue* ExtensionTabUtil::OpenTab(
   // We can't load extension URLs into incognito windows unless the extension
   // uses split mode. Special case to fall back to a tabbed window.
   if (url.SchemeIs(kExtensionScheme) &&
-      !IncognitoInfo::IsSplitMode(function->extension()) &&
+      (!function->extension() ||

[benwells, 2017/05/22 02:59:31]

I would have thought (function->extension &&... would be more appropriate here.

[calamity, 2017/05/22 03:02:32]

I think we want to hit the fallback behavior in this case, and assume that this
non-extension is not in split mode. I'm happy to defer to your judgment though.

[benwells, 2017/05/22 05:29:43]

OK ... so like !(function->extension() && function->extension()->IsSplitMode())

yeah that makes sense :)

+       !IncognitoInfo::IsSplitMode(function->extension())) &&
       browser->profile()->IsOffTheRecord()) {
     Profile* profile = browser->profile()->GetOriginalProfile();