Supersize: Chrome-specific breakdowns, console tweaks

Supersize: Chrome-specific breakdowns, console tweaks

Adds two chrome-specific categorizing functions:
 * CategorizeByChromeComponent()
 * CategorizeGenerated()

Console Enhancements:
* Make console Print() and Diff() parameters optional
* Show symbol indexes when printing (and doort by default, which
  invalidates indices)
* Single-line output for a list of groups
* Show a decimal for pss < 10 (so it's clear the symbol is shared)
* Show running total percentage alongside running total
* Fix SymbolGroup header sizes to be recursively calculated

README update

BUG=681694
Review-Url: https://codereview.chromium.org/2864063002
Cr-Commit-Position: refs/heads/master@{#469874}
Committed: https://chromium.googlesource.com/chromium/src/+/9c9cc15d81514bb92abaa3252c7c7b01c3e47bc4

[agrieve, 2017-05-05 20:37:50]

Description was changed from

==========
Supersize: Chrome-specific breakdowns, console tweaks

Adds two chrome-specific categorizing functions:
 * CategorizeByChromeComponent()
 * CategorizeGenerated()

Console Enhancements:
* Make console Print() and Diff() parameters optional
* Show symbol indexes when printing (and doort by default, which
  invalidates indices)
* Single-line output for a list of groups
* Show a decimal for pss < 10 (so it's clear the symbol is shared)
* Show running total percentage alongside running total
* Fix SymbolGroup header sizes to be recursively calculated

README update

BUG=681694
==========

to

==========
Supersize: Chrome-specific breakdowns, console tweaks

Adds two chrome-specific categorizing functions:
 * CategorizeByChromeComponent()
 * CategorizeGenerated()

Console Enhancements:
* Make console Print() and Diff() parameters optional
* Show symbol indexes when printing (and doort by default, which
  invalidates indices)
* Single-line output for a list of groups
* Show a decimal for pss < 10 (so it's clear the symbol is shared)
* Show running total percentage alongside running total
* Fix SymbolGroup header sizes to be recursively calculated

README update

BUG=681694
==========

[agrieve, 2017-05-05 20:37:50]

agrieve@chromium.org changed reviewers:
+ estevenson@chromium.org

[agrieve, 2017-05-05 20:37:57]

On 2017/05/05 20:37:50, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:estevenson@chromium.org

🐗

[estevenson, 2017-05-05 22:24:18]

git cl patch failed me so I couldn't test it out :(.

lgtm, excited to see what precanned_queries looks like once I can try it out!

https://codereview.chromium.org/2864063002/diff/1/tools/binary_size/libsupers...
File tools/binary_size/libsupersize/console.py (right):

https://codereview.chromium.org/2864063002/diff/1/tools/binary_size/libsupers...
tools/binary_size/libsupersize/console.py:25: import precanned_queries
nit/name bikeshed: the "pre" in precanned_queries may be unnecessary?

https://codereview.chromium.org/2864063002/diff/1/tools/binary_size/libsupers...
tools/binary_size/libsupersize/console.py:97: before = before if before is not
None else self._size_infos[0]
nit: before or self.size_infos[0]? (+ obj in _PrintFunc and arg in _Categorize*
below)

https://codereview.chromium.org/2864063002/diff/1/tools/binary_size/libsupers...
tools/binary_size/libsupersize/console.py:183: print self._CreateBanner()
Might even be worth saying "Take a look at precanned_querys.py for more
examples" in the examples below.

https://codereview.chromium.org/2864063002/diff/1/tools/binary_size/libsupers...
tools/binary_size/libsupersize/console.py:214:
'Print(c[-1].GroupByPath(depth=2))',
nit: maybe specify what "other" is here?

https://codereview.chromium.org/2864063002/diff/1/tools/binary_size/libsupers...
File tools/binary_size/libsupersize/precanned_queries.py (right):

https://codereview.chromium.org/2864063002/diff/1/tools/binary_size/libsupers...
tools/binary_size/libsupersize/precanned_queries.py:89: def
CategorizeGenerated(symbols):
Could add jni here? Might be super small though.

[agrieve, 2017-05-06 01:18:22]

https://codereview.chromium.org/2864063002/diff/1/tools/binary_size/libsupers...
File tools/binary_size/libsupersize/console.py (right):

https://codereview.chromium.org/2864063002/diff/1/tools/binary_size/libsupers...
tools/binary_size/libsupersize/console.py:25: import precanned_queries
On 2017/05/05 22:24:18, estevenson wrote:
> nit/name bikeshed: the "pre" in precanned_queries may be unnecessary? 

true. Done.

https://codereview.chromium.org/2864063002/diff/1/tools/binary_size/libsupers...
tools/binary_size/libsupersize/console.py:97: before = before if before is not
None else self._size_infos[0]
On 2017/05/05 22:24:18, estevenson wrote:
> nit: before or self.size_infos[0]? (+ obj in _PrintFunc and arg in
_Categorize*
> below)

I had that before, but turns out it's wrong in the context of PrintFunc, where
if you pass it an empty group, it evaluates to False (because of __len__).

https://codereview.chromium.org/2864063002/diff/1/tools/binary_size/libsupers...
tools/binary_size/libsupersize/console.py:183: print self._CreateBanner()
On 2017/05/05 22:24:18, estevenson wrote:
> Might even be worth saying "Take a look at precanned_querys.py for more
> examples" in the examples below.

Done.

https://codereview.chromium.org/2864063002/diff/1/tools/binary_size/libsupers...
tools/binary_size/libsupersize/console.py:214:
'Print(c[-1].GroupByPath(depth=2))',
On 2017/05/05 22:24:18, estevenson wrote:
> nit: maybe specify what "other" is here?

Changed to "last element"

https://codereview.chromium.org/2864063002/diff/1/tools/binary_size/libsupers...
File tools/binary_size/libsupersize/precanned_queries.py (right):

https://codereview.chromium.org/2864063002/diff/1/tools/binary_size/libsupers...
tools/binary_size/libsupersize/precanned_queries.py:89: def
CategorizeGenerated(symbols):
On 2017/05/05 22:24:18, estevenson wrote:
> Could add jni here? Might be super small though.

Done. ~50kb. But the number doesn't capture many of the string literals
involved. Reworking the jni generator so that it assigns all string literals to
variable names would make them show up.

[agrieve, 2017-05-06 01:20:17]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2017-05-06 01:20:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
estevenson@chromium.org
Link to the patchset: https://codereview.chromium.org/2864063002/#ps20001
(title: "review tweaks")

[commit-bot: I haz the power, 2017-05-06 01:20:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-06 19:14:11]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494033617176030,
"parent_rev": "83f8bbb8ac2dbe76c00360bfd7c99ac09a458d0b", "commit_rev":
"9c9cc15d81514bb92abaa3252c7c7b01c3e47bc4"}

[commit-bot: I haz the power, 2017-05-06 19:14:25]

Description was changed from

==========
Supersize: Chrome-specific breakdowns, console tweaks

Adds two chrome-specific categorizing functions:
 * CategorizeByChromeComponent()
 * CategorizeGenerated()

Console Enhancements:
* Make console Print() and Diff() parameters optional
* Show symbol indexes when printing (and doort by default, which
  invalidates indices)
* Single-line output for a list of groups
* Show a decimal for pss < 10 (so it's clear the symbol is shared)
* Show running total percentage alongside running total
* Fix SymbolGroup header sizes to be recursively calculated

README update

BUG=681694
==========

to

==========
Supersize: Chrome-specific breakdowns, console tweaks

Adds two chrome-specific categorizing functions:
 * CategorizeByChromeComponent()
 * CategorizeGenerated()

Console Enhancements:
* Make console Print() and Diff() parameters optional
* Show symbol indexes when printing (and doort by default, which
  invalidates indices)
* Single-line output for a list of groups
* Show a decimal for pss < 10 (so it's clear the symbol is shared)
* Show running total percentage alongside running total
* Fix SymbolGroup header sizes to be recursively calculated

README update

BUG=681694

Review-Url: https://codereview.chromium.org/2864063002
Cr-Commit-Position: refs/heads/master@{#469874}
Committed:
https://chromium.googlesource.com/chromium/src/+/9c9cc15d81514bb92abaa3252c7c...
==========

[commit-bot: I haz the power, 2017-05-06 19:14:26]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9c9cc15d81514bb92abaa3252c7c...