Supersize: Store whether source path was generated in flags

Supersize: Store whether source path was generated in flags

This information is lost as part of normalization, but it's useful to
know.

BUG=681694
Review-Url: https://codereview.chromium.org/2863753005
Cr-Commit-Position: refs/heads/master@{#469835}
Committed: https://chromium.googlesource.com/chromium/src/+/04adc8218cbb4e00dfe6dfa3acd95d07548ed54f

[agrieve, 2017-05-05 18:53:09]

Description was changed from

==========
Supersize: Store whether source path was generated in flags

This information is lost as part of normalization, but it's useful to
know.

BUG=681694
==========

to

==========
Supersize: Store whether source path was generated in flags

This information is lost as part of normalization, but it's useful to
know.

BUG=681694
==========

[agrieve, 2017-05-05 18:53:09]

agrieve@chromium.org changed reviewers:
+ estevenson@chromium.org

[agrieve, 2017-05-05 18:53:26]

On 2017/05/05 18:53:09, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:estevenson@chromium.org

🐒

[estevenson, 2017-05-05 19:14:58]

lgtm

https://codereview.chromium.org/2863753005/diff/1/tools/binary_size/libsupers...
File tools/binary_size/libsupersize/models.py (right):

https://codereview.chromium.org/2863753005/diff/1/tools/binary_size/libsupers...
tools/binary_size/libsupersize/models.py:318: first = self._symbols[0].address
if self else 0
probably obvious but what is the "if self" for?

https://codereview.chromium.org/2863753005/diff/1/tools/binary_size/libsupers...
tools/binary_size/libsupersize/models.py:456: def WhereFullNameMatches(self,
pattern):
Does it make sense to just add this to WhereNameMatches above?

[agrieve, 2017-05-06 00:37:29]

https://codereview.chromium.org/2863753005/diff/1/tools/binary_size/libsupers...
File tools/binary_size/libsupersize/models.py (right):

https://codereview.chromium.org/2863753005/diff/1/tools/binary_size/libsupers...
tools/binary_size/libsupersize/models.py:318: first = self._symbols[0].address
if self else 0
On 2017/05/05 19:14:58, estevenson wrote:
> probably obvious but what is the "if self" for?

it checks for the case of a SymbolGroup with no children.

https://codereview.chromium.org/2863753005/diff/1/tools/binary_size/libsupers...
tools/binary_size/libsupersize/models.py:456: def WhereFullNameMatches(self,
pattern):
On 2017/05/05 19:14:58, estevenson wrote:
> Does it make sense to just add this to WhereNameMatches above?

This is certainly a place where I'm not sure what the right API should really
look like, and that working on analyzing some templates might make it become
more clear.

Nothing's using this at the moment, but I wanted for a manual query I ran so
just left it in.

Going to just stick with it for now, but happy to discuss later changes to these
things.

[agrieve, 2017-05-06 00:37:32]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2017-05-06 00:38:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-06 00:53:21]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494031052838950, "parent_rev":
"cf2cc68d4e6a4a70bcadfd5491f90d119129ec38", "commit_rev":
"04adc8218cbb4e00dfe6dfa3acd95d07548ed54f"}

[commit-bot: I haz the power, 2017-05-06 00:53:33]

Description was changed from

==========
Supersize: Store whether source path was generated in flags

This information is lost as part of normalization, but it's useful to
know.

BUG=681694
==========

to

==========
Supersize: Store whether source path was generated in flags

This information is lost as part of normalization, but it's useful to
know.

BUG=681694

Review-Url: https://codereview.chromium.org/2863753005
Cr-Commit-Position: refs/heads/master@{#469835}
Committed:
https://chromium.googlesource.com/chromium/src/+/04adc8218cbb4e00dfe6dfa3acd9...
==========

[commit-bot: I haz the power, 2017-05-06 00:53:34]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/04adc8218cbb4e00dfe6dfa3acd9...