tools/binary_size/libsupersize/file_format.py - Issue 2864063002: Supersize: Chrome-specific breakdowns, console tweaks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/binary_size/libsupersize/file_format.py

Issue 2864063002: Supersize: Chrome-specific breakdowns, console tweaks (Closed)

Patch Set: review tweaks Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/binary_size/libsupersize/file_format.py

diff --git a/tools/binary_size/libsupersize/file_format.py b/tools/binary_size/libsupersize/file_format.py

index e58494daacc7e557bc587308824dce87fa82fcf5..63c44b604b223a6d19a4f79a859dfa29d8f01bce 100644

--- a/tools/binary_size/libsupersize/file_format.py

+++ b/tools/binary_size/libsupersize/file_format.py

@@ -53,8 +53,8 @@ def _SaveSizeInfoToFile(size_info, file_obj):

_LogSize(file_obj, 'paths') # For libchrome, adds 200kb.

# Symbol counts by section.

- by_section = models.SymbolGroup(size_info.symbols)

- by_section = by_section.GroupBySectionName().SortedByName()

+ by_section = size_info.symbols.GroupBySectionName().Sorted(

+ key=lambda s:(s[0].IsBss(), s[0].address, s.name))

file_obj.write('%s\n' % '\t'.join(g.name for g in by_section))

file_obj.write('%s\n' % '\t'.join(str(len(g)) for g in by_section))