A11y: Rename AXSupportedAction to AXDefaultActionVerb.

A11y: Rename AXSupportedAction to AXDefaultActionVerb.

The AXSupportedAction enum is used to identify the appropriate string to use
when a11y clients need to know the action that will occur on an a11y element
when performing the default action, which is a click. Avoid any confusion with
the AXActions an a11y element supports by renaming it.

BUG=717846
Review-Url: https://codereview.chromium.org/2863703003
Cr-Commit-Position: refs/heads/master@{#472715}
Committed: https://chromium.googlesource.com/chromium/src/+/fee367ad5f048733aba40a3a7b64ddb7967355dc

[Patti Lor, 2017-05-05 09:28:40]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 09:28:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 09:32:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 09:32:33]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Patti Lor, 2017-05-08 04:22:08]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 04:22:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 04:53:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 04:53:49]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Patti Lor, 2017-05-08 05:57:11]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 05:57:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Patti Lor, 2017-05-09 00:58:09]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 01:18:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 04:08:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 04:08:28]

Dry run: This issue passed the CQ dry run.

[Patti Lor, 2017-05-09 07:52:10]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 07:52:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 11:53:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 11:53:47]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Patti Lor, 2017-05-12 00:47:01]

patricialor@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[Patti Lor, 2017-05-12 00:47:03]

Hi dmazzoni, PTAL? Thanks.

[dmazzoni, 2017-05-12 03:08:58]

lgtm

https://codereview.chromium.org/2863703003/diff/80001/content/browser/accessi...
File content/browser/accessibility/browser_accessibility_auralinux.cc (right):

https://codereview.chromium.org/2863703003/diff/80001/content/browser/accessi...
content/browser/accessibility/browser_accessibility_auralinux.cc:101:
base::string16 action_verb = ui::ActionToUnlocalizedString(
Maybe this should be ActionVerbToUnlocalizedString

https://codereview.chromium.org/2863703003/diff/80001/content/browser/accessi...
File content/browser/accessibility/browser_accessibility_win.cc (right):

https://codereview.chromium.org/2863703003/diff/80001/content/browser/accessi...
content/browser/accessibility/browser_accessibility_win.cc:2800:
ui::ActionToString(static_cast<ui::AXDefaultActionVerb>(action));
And this one should be ActionVerbToLocalizedString...

[Patti Lor, 2017-05-12 08:10:42]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 08:10:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 08:14:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 08:14:02]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Patti Lor, 2017-05-15 01:43:55]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 01:44:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 02:29:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 02:29:55]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Patti Lor, 2017-05-15 02:44:24]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 02:44:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 05:17:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 05:17:53]

Dry run: This issue passed the CQ dry run.

[Patti Lor, 2017-05-15 06:03:41]

patricialor@chromium.org changed reviewers:
+ mkwst@chromium.org, sky@chromium.org

[Patti Lor, 2017-05-15 06:03:42]

Hi sky, PTAL for:
ui/* and chrome/browser/*

mkwst, PTAL for:
third_party/WebKit/*

Thanks all!

https://codereview.chromium.org/2863703003/diff/80001/content/browser/accessi...
File content/browser/accessibility/browser_accessibility_auralinux.cc (right):

https://codereview.chromium.org/2863703003/diff/80001/content/browser/accessi...
content/browser/accessibility/browser_accessibility_auralinux.cc:101:
base::string16 action_verb = ui::ActionToUnlocalizedString(
On 2017/05/12 03:08:58, dmazzoni wrote:
> Maybe this should be ActionVerbToUnlocalizedString

Done.

https://codereview.chromium.org/2863703003/diff/80001/content/browser/accessi...
File content/browser/accessibility/browser_accessibility_win.cc (right):

https://codereview.chromium.org/2863703003/diff/80001/content/browser/accessi...
content/browser/accessibility/browser_accessibility_win.cc:2800:
ui::ActionToString(static_cast<ui::AXDefaultActionVerb>(action));
On 2017/05/12 03:08:58, dmazzoni wrote:
> And this one should be ActionVerbToLocalizedString...

Done.

[Mike West, 2017-05-15 07:36:42]

third_party/WebKit LGTM.

[sky, 2017-05-15 15:42:40]

LGTM

[Patti Lor, 2017-05-16 00:40:02]

The CQ bit was checked by patricialor@chromium.org

[Patti Lor, 2017-05-16 00:40:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2863703003/#ps140001
(title: "Fix Windows compile from rebase.")

[commit-bot: I haz the power, 2017-05-16 00:41:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 01:21:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 01:21:02]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Patti Lor, 2017-05-16 03:03:07]

The CQ bit was checked by patricialor@chromium.org

[Patti Lor, 2017-05-16 03:03:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org, mkwst@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2863703003/#ps160001
(title: "Rebase again.")

[commit-bot: I haz the power, 2017-05-16 03:03:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 05:16:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 05:16:32]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Patti Lor, 2017-05-17 03:54:38]

The CQ bit was checked by patricialor@chromium.org

[commit-bot: I haz the power, 2017-05-17 03:55:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 04:01:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 04:01:45]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Patti Lor, 2017-05-17 05:21:51]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 05:22:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 07:34:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 07:34:41]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Patti Lor, 2017-05-17 07:56:55]

The CQ bit was checked by patricialor@chromium.org

[Patti Lor, 2017-05-17 07:56:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org, mkwst@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2863703003/#ps180001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-17 07:57:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 08:04:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 08:04:13]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Patti Lor, 2017-05-18 01:45:28]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 01:46:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 03:20:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 03:20:18]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Patti Lor, 2017-05-18 06:44:52]

The CQ bit was checked by patricialor@chromium.org

[Patti Lor, 2017-05-18 06:44:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org, mkwst@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2863703003/#ps200001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-05-18 06:45:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 06:52:06]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1495089892792850,
"parent_rev": "92860763bac3133a6729756f0f7899f69c22e9b2", "commit_rev":
"fee367ad5f048733aba40a3a7b64ddb7967355dc"}

[commit-bot: I haz the power, 2017-05-18 06:52:20]

Description was changed from

==========
A11y: Rename AXSupportedAction to AXDefaultActionVerb.

The AXSupportedAction enum is used to identify the appropriate string to use
when a11y clients need to know the action that will occur on an a11y element
when performing the default action, which is a click. Avoid any confusion with
the AXActions an a11y element supports by renaming it.

BUG=717846
==========

to

==========
A11y: Rename AXSupportedAction to AXDefaultActionVerb.

The AXSupportedAction enum is used to identify the appropriate string to use
when a11y clients need to know the action that will occur on an a11y element
when performing the default action, which is a click. Avoid any confusion with
the AXActions an a11y element supports by renaming it.

BUG=717846

Review-Url: https://codereview.chromium.org/2863703003
Cr-Commit-Position: refs/heads/master@{#472715}
Committed:
https://chromium.googlesource.com/chromium/src/+/fee367ad5f048733aba40a3a7b64...
==========

[commit-bot: I haz the power, 2017-05-18 06:52:21]

Committed patchset #11 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/fee367ad5f048733aba40a3a7b64...