Ignore print() during page dismissal.

Ignore print() during page dismissal.

Blink intent thread: https://groups.google.com/a/chromium.org/d/msg/blink-dev/sBE6zziflmQ/5eiD0yh7BAAJ

BUG=706319
Review-Url: https://codereview.chromium.org/2863203002
Cr-Commit-Position: refs/heads/master@{#474117}
Committed: https://chromium.googlesource.com/chromium/src/+/f9e6c47b2075f812ea974cf72df85b35a5936ebe

[lfg, 2017-05-05 19:47:47]

The CQ bit was checked by lfg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 19:48:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 20:01:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 20:01:14]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[lfg, 2017-05-05 21:06:10]

The CQ bit was checked by lfg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 21:06:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 22:47:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 22:47:09]

Dry run: This issue passed the CQ dry run.

[lfg, 2017-05-08 16:27:43]

lfg@chromium.org changed reviewers:
+ dcheng@chromium.org

[lfg, 2017-05-08 16:27:44]

Daniel, can you review?

[dcheng, 2017-05-08 19:27:17]

Does this need an intent to implement/ship?

[lfg, 2017-05-19 19:38:14]

Description was changed from

==========
Ignore print() during page dismissal.

BUG=706319
==========

to

==========
Ignore print() during page dismissal.

Blink intent thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/sBE6zziflmQ/5eiD0yh7...

BUG=706319
==========

[lfg, 2017-05-19 19:38:47]

On 2017/05/08 19:27:17, dcheng (in AEST) wrote:
> Does this need an intent to implement/ship?

Daniel, I updated the description with the intent, can you take a look again?

[dcheng, 2017-05-19 21:45:04]

LGTM

[lfg, 2017-05-20 01:43:57]

The CQ bit was checked by lfg@chromium.org

[commit-bot: I haz the power, 2017-05-20 01:44:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-20 01:54:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-20 01:54:31]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[lfg, 2017-05-23 17:31:05]

lfg@chromium.org changed reviewers:
+ alexmos@chromium.org

[lfg, 2017-05-23 17:31:06]

Alex, can you review the test in content/ ?

[lfg, 2017-05-23 17:31:17]

The CQ bit was checked by lfg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 17:32:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alexmos, 2017-05-23 18:01:19]

Test LGTM with nit

https://codereview.chromium.org/2863203002/diff/20001/chrome/browser/chrome_s...
File chrome/browser/chrome_site_per_process_browsertest.cc (right):

https://codereview.chromium.org/2863203002/diff/20001/chrome/browser/chrome_s...
chrome/browser/chrome_site_per_process_browsertest.cc:520:
IN_PROC_BROWSER_TEST_F(ChromeSitePerProcessTest, PrintOnUnloadHandler) {
nit: the name makes it sound like we're expecting print to still work in unload.
:)  PrintIgnoredInUnloadHandler, perhaps?

[lfg, 2017-05-23 18:38:49]

The CQ bit was checked by lfg@chromium.org to run a CQ dry run

[lfg, 2017-05-23 18:38:52]

https://codereview.chromium.org/2863203002/diff/20001/chrome/browser/chrome_s...
File chrome/browser/chrome_site_per_process_browsertest.cc (right):

https://codereview.chromium.org/2863203002/diff/20001/chrome/browser/chrome_s...
chrome/browser/chrome_site_per_process_browsertest.cc:520:
IN_PROC_BROWSER_TEST_F(ChromeSitePerProcessTest, PrintOnUnloadHandler) {
On 2017/05/23 18:01:19, alexmos wrote:
> nit: the name makes it sound like we're expecting print to still work in
unload.
> :)  PrintIgnoredInUnloadHandler, perhaps?

Done.

[commit-bot: I haz the power, 2017-05-23 18:39:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 21:37:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 21:37:41]

Dry run: This issue passed the CQ dry run.

[lfg, 2017-05-24 00:02:23]

The CQ bit was checked by lfg@chromium.org

[lfg, 2017-05-24 00:02:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
alexmos@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2863203002/#ps40001
(title: "rebase, addressing comments")

[commit-bot: I haz the power, 2017-05-24 00:03:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 00:16:36]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495584143532030,
"parent_rev": "2d391fc58e0f24b5d33fadb80527dd2b81193d43", "commit_rev":
"f9e6c47b2075f812ea974cf72df85b35a5936ebe"}

[commit-bot: I haz the power, 2017-05-24 00:16:47]

Description was changed from

==========
Ignore print() during page dismissal.

Blink intent thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/sBE6zziflmQ/5eiD0yh7...

BUG=706319
==========

to

==========
Ignore print() during page dismissal.

Blink intent thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/sBE6zziflmQ/5eiD0yh7...

BUG=706319

Review-Url: https://codereview.chromium.org/2863203002
Cr-Commit-Position: refs/heads/master@{#474117}
Committed:
https://chromium.googlesource.com/chromium/src/+/f9e6c47b2075f812ea974cf72df8...
==========

[commit-bot: I haz the power, 2017-05-24 00:16:48]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f9e6c47b2075f812ea974cf72df8...