Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Side by Side Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 2863203002: Ignore print() during page dismissal. (Closed)
Patch Set: rebase, addressing comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/page/ChromeClient.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 namespace { 132 namespace {
133 133
134 const char* DialogTypeToString(ChromeClient::DialogType dialog_type) { 134 const char* DialogTypeToString(ChromeClient::DialogType dialog_type) {
135 switch (dialog_type) { 135 switch (dialog_type) {
136 case ChromeClient::kAlertDialog: 136 case ChromeClient::kAlertDialog:
137 return "alert"; 137 return "alert";
138 case ChromeClient::kConfirmDialog: 138 case ChromeClient::kConfirmDialog:
139 return "confirm"; 139 return "confirm";
140 case ChromeClient::kPromptDialog: 140 case ChromeClient::kPromptDialog:
141 return "prompt"; 141 return "prompt";
142 case ChromeClient::kPrintDialog:
143 return "print";
142 case ChromeClient::kHTMLDialog: 144 case ChromeClient::kHTMLDialog:
143 NOTREACHED(); 145 NOTREACHED();
144 } 146 }
145 NOTREACHED(); 147 NOTREACHED();
146 return ""; 148 return "";
147 } 149 }
148 150
149 const char* DismissalTypeToString(Document::PageDismissalType dismissal_type) { 151 const char* DismissalTypeToString(Document::PageDismissalType dismissal_type) {
150 switch (dismissal_type) { 152 switch (dismissal_type) {
151 case Document::kBeforeUnloadDismissal: 153 case Document::kBeforeUnloadDismissal:
(...skipping 1108 matching lines...) Expand 10 before | Expand all | Expand 10 after
1260 if (RuntimeEnabledFeatures::presentationEnabled()) 1262 if (RuntimeEnabledFeatures::presentationEnabled())
1261 PresentationController::ProvideTo(frame, client->PresentationClient()); 1263 PresentationController::ProvideTo(frame, client->PresentationClient());
1262 if (RuntimeEnabledFeatures::audioOutputDevicesEnabled()) { 1264 if (RuntimeEnabledFeatures::audioOutputDevicesEnabled()) {
1263 ProvideAudioOutputDeviceClientTo(frame, 1265 ProvideAudioOutputDeviceClientTo(frame,
1264 new AudioOutputDeviceClientImpl(frame)); 1266 new AudioOutputDeviceClientImpl(frame));
1265 } 1267 }
1266 InstalledAppController::ProvideTo(frame, client->GetRelatedAppsFetcher()); 1268 InstalledAppController::ProvideTo(frame, client->GetRelatedAppsFetcher());
1267 } 1269 }
1268 1270
1269 } // namespace blink 1271 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/page/ChromeClient.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698