third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp - Issue 2863203002: Ignore print() during page dismissal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp

Issue 2863203002: Ignore print() during page dismissal. (Closed)

Patch Set: rebase, addressing comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp

index cc099a0ece5228f46d497f8c992c58385c34314c..f95657b93ef11e4fba14007571ce85585e42aae1 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp

@@ -106,6 +106,8 @@ String DialogTypeToProtocol(ChromeClient::DialogType dialog_type) {

return protocol::Page::DialogTypeEnum::Prompt;

case ChromeClient::kHTMLDialog:

return protocol::Page::DialogTypeEnum::Beforeunload;

+ case ChromeClient::kPrintDialog:

+ NOTREACHED();

}

return protocol::Page::DialogTypeEnum::Alert;

}