Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2863143002: Revert of Don't set cpu architecture field on iOS in UMA logs. (patchset #2 id:20001 of https://cod… (Closed)

Created:
3 years, 7 months ago by sczs
Modified:
3 years, 7 months ago
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Revert of Don't set cpu architecture field on iOS in UMA logs. (patchset #2 id:20001 of https://codereview.chromium.org/2671433002/ ) Reason for revert: This breaks Chrome iOS dashboards because cpu_architecture is the only field where we have the device model info (e.g. iPhone7,2). Original issue's description: > Don't set cpu architecture field on iOS in UMA logs. > > The value we were setting it to before was not correct, so this > change instead just makes the value not get set on iOS. > > BUG=370104 > > Review-Url: https://codereview.chromium.org/2671433002 > Cr-Commit-Position: refs/heads/master@{#447578} > Committed: https://chromium.googlesource.com/chromium/src/+/a86e8e115054ad167458d0379980db5473cb20de TBR=rkaplow@chromium.org,asvitkine@chromium.org BUG=370104, 718080 Review-Url: https://codereview.chromium.org/2855943005 Cr-Commit-Position: refs/heads/master@{#469062} (cherry picked from commit 9f89092a8f533da1537b0a441b1e137b3d3b2728) Review-Url: https://codereview.chromium.org/2863143002 . Cr-Commit-Position: refs/branch-heads/3029@{#803} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/a0532b2e7b14f5c68d294a2faa6c03315ba5fd93

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M components/metrics/metrics_log.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M components/metrics/metrics_log_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
sczs
3 years, 7 months ago (2017-05-05 15:08:21 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a0532b2e7b14f5c68d294a2faa6c03315ba5fd93.

Powered by Google App Engine
This is Rietveld 408576698