Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: components/metrics/metrics_log.cc

Issue 2863143002: Revert of Don't set cpu architecture field on iOS in UMA logs. (patchset #2 id:20001 of https://cod… (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/metrics/metrics_log_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics/metrics_log.cc
diff --git a/components/metrics/metrics_log.cc b/components/metrics/metrics_log.cc
index ac35ce396a32a8f06f1a7a7d913953cbb161e290..42331e3f15b01b474dd22eda373830ef71a42db1 100644
--- a/components/metrics/metrics_log.cc
+++ b/components/metrics/metrics_log.cc
@@ -151,12 +151,7 @@ void MetricsLog::RecordCoreSystemProfile(MetricsServiceClient* client,
metrics::SystemProfileProto::Hardware* hardware =
system_profile->mutable_hardware();
-#if !defined(OS_IOS)
- // On iOS, OperatingSystemArchitecture() returns values like iPad4,4 which is
- // not the actual CPU architecture. Don't set it until the API is fixed. See
- // crbug.com/370104 for details.
hardware->set_cpu_architecture(base::SysInfo::OperatingSystemArchitecture());
-#endif
hardware->set_system_ram_mb(base::SysInfo::AmountOfPhysicalMemoryMB());
hardware->set_hardware_class(base::SysInfo::HardwareModelName());
#if defined(OS_WIN)
« no previous file with comments | « no previous file | components/metrics/metrics_log_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698