Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 2671433002: Don't set cpu architecture field on iOS in UMA logs. (Closed)

Created:
3 years, 10 months ago by Alexei Svitkine (slow)
Modified:
3 years, 10 months ago
Reviewers:
rkaplow
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't set cpu architecture field on iOS in UMA logs. The value we were setting it to before was not correct, so this change instead just makes the value not get set on iOS. BUG=370104 Review-Url: https://codereview.chromium.org/2671433002 Cr-Commit-Position: refs/heads/master@{#447578} Committed: https://chromium.googlesource.com/chromium/src/+/a86e8e115054ad167458d0379980db5473cb20de

Patch Set 1 #

Patch Set 2 : Fix test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M components/metrics/metrics_log.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M components/metrics/metrics_log_unittest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
Alexei Svitkine (slow)
3 years, 10 months ago (2017-02-01 01:37:34 UTC) #3
rkaplow
lgtm
3 years, 10 months ago (2017-02-01 01:39:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2671433002/1
3 years, 10 months ago (2017-02-01 01:43:48 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/146976)
3 years, 10 months ago (2017-02-01 02:00:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2671433002/20001
3 years, 10 months ago (2017-02-01 18:09:53 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/a86e8e115054ad167458d0379980db5473cb20de
3 years, 10 months ago (2017-02-01 19:34:42 UTC) #20
pkl (ping after 24h if needed)
3 years, 7 months ago (2017-05-03 17:20:35 UTC) #21
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2855943005/ by pkl@chromium.org.

The reason for reverting is: This breaks Chrome iOS dashboards because
cpu_architecture is the only field where we have the device model info (e.g.
iPhone7,2)..

Powered by Google App Engine
This is Rietveld 408576698