Run BoringSSL tests on iOS bots.

Run BoringSSL tests on iOS bots.

BUG=

Review-Url: https://codereview.chromium.org/2862983002
Cr-Commit-Position: refs/heads/master@{#469994}
Committed: https://chromium.googlesource.com/chromium/src/+/1034b8e83ee2263bd9be2ed6a58570b7f9ae8559

[davidben, 2017-05-04 21:33:31]

The CQ bit was checked by davidben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 21:33:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 22:53:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 22:53:10]

Dry run: This issue passed the CQ dry run.

[davidben, 2017-05-05 16:27:59]

davidben@chromium.org changed reviewers:
+ smut@google.com

[davidben, 2017-05-05 16:27:59]

question: Looking at the try bots, the only bot that seemed to run the tests is
ios-simulator... is there one that runs it on device? The main reason we'd like
BoringSSL tests on iOS is we have arch+platform-specific assembly. Right now
that's disabled on iOS due to lack of testing, but we'd like to fix that.
(Crypto code typically needs assembly to run at reasonable performance. It's one
of the few throughput-sensitive operations we have lying around.)

[smut, 2017-05-05 22:55:15]

On 2017/05/05 16:27:59, davidben wrote:
> question: Looking at the try bots, the only bot that seemed to run the tests
is
> ios-simulator... is there one that runs it on device? The main reason we'd
like
> BoringSSL tests on iOS is we have arch+platform-specific assembly. Right now
> that's disabled on iOS due to lack of testing, but we'd like to fix that.
> (Crypto code typically needs assembly to run at reasonable performance. It's
one
> of the few throughput-sensitive operations we have lying around.)

Lgtm. There are no iOS devices upstream. The ios-device builder just does the
ARM compilation.

[davidben, 2017-05-08 14:34:41]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2017-05-08 14:35:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 15:53:08]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494254081640340, "parent_rev":
"3919a2d21a0c3df90ab7077aa6ebee97262dfd29", "commit_rev":
"1034b8e83ee2263bd9be2ed6a58570b7f9ae8559"}

[commit-bot: I haz the power, 2017-05-08 15:53:24]

Description was changed from

==========
Run BoringSSL tests on iOS bots.

BUG=
==========

to

==========
Run BoringSSL tests on iOS bots.

BUG=

Review-Url: https://codereview.chromium.org/2862983002
Cr-Commit-Position: refs/heads/master@{#469994}
Committed:
https://chromium.googlesource.com/chromium/src/+/1034b8e83ee2263bd9be2ed6a585...
==========

[commit-bot: I haz the power, 2017-05-08 15:53:25]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1034b8e83ee2263bd9be2ed6a585...

[baxley, 2017-05-08 17:10:05]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2872673002/ by baxley@chromium.org.

The reason for reverting is: This appears to be blocking ios-simulator on the
CQ. I think we need to update gn_isolate_map.pyl ?

Error from logs:
MBErr: target "boringssl_crypto_tests" not found in
//testing/buildbot/gn_isolate_map.pyl
target "boringssl_ssl_tests" not found in //testing/buildbot/gn_isolate_map.pyl.

[davidben, 2017-05-08 17:11:09]

On 2017/05/08 17:10:05, baxley wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/2872673002/ by mailto:baxley@chromium.org.
> 
> The reason for reverting is: This appears to be blocking ios-simulator on the
> CQ. I think we need to update gn_isolate_map.pyl ?
> 
> Error from logs:
> MBErr: target "boringssl_crypto_tests" not found in
> //testing/buildbot/gn_isolate_map.pyl
> target "boringssl_ssl_tests" not found in
//testing/buildbot/gn_isolate_map.pyl.

Oh, whoops. My bad, I didn't realize they needed to land in the other order.
(Weird, I wonder why the CQ let me land it.)