Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2872673002: Revert of Run BoringSSL tests on iOS bots. (Closed)

Created:
3 years, 7 months ago by baxley
Modified:
3 years, 7 months ago
Reviewers:
smut, davidben
CC:
chromium-reviews, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Run BoringSSL tests on iOS bots. (patchset #1 id:1 of https://codereview.chromium.org/2862983002/ ) Reason for revert: This appears to be blocking ios-simulator on the CQ. I think we need to update gn_isolate_map.pyl ? Error from logs: MBErr: target "boringssl_crypto_tests" not found in //testing/buildbot/gn_isolate_map.pyl target "boringssl_ssl_tests" not found in //testing/buildbot/gn_isolate_map.pyl Original issue's description: > Run BoringSSL tests on iOS bots. > > BUG= > > Review-Url: https://codereview.chromium.org/2862983002 > Cr-Commit-Position: refs/heads/master@{#469994} > Committed: https://chromium.googlesource.com/chromium/src/+/1034b8e83ee2263bd9be2ed6a58570b7f9ae8559 TBR=smut@google.com,davidben@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2872673002 Cr-Commit-Position: refs/heads/master@{#470026} Committed: https://chromium.googlesource.com/chromium/src/+/f42a25f36d9ae587b3b8f2c584c4c3075cc24f2f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M ios/build/bots/tests/common_tests.json View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
baxley
Created Revert of Run BoringSSL tests on iOS bots.
3 years, 7 months ago (2017-05-08 17:10:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872673002/1
3 years, 7 months ago (2017-05-08 17:10:33 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/f42a25f36d9ae587b3b8f2c584c4c3075cc24f2f
3 years, 7 months ago (2017-05-08 17:11:10 UTC) #6
smut
On 2017/05/08 17:11:10, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
3 years, 7 months ago (2017-05-09 23:29:48 UTC) #7
smut
On 2017/05/09 23:29:48, smut wrote: > On 2017/05/08 17:11:10, commit-bot: I haz the power wrote: ...
3 years, 7 months ago (2017-05-09 23:31:25 UTC) #8
davidben
On 2017/05/09 23:31:25, smut wrote: > On 2017/05/09 23:29:48, smut wrote: > > On 2017/05/08 ...
3 years, 7 months ago (2017-05-09 23:36:05 UTC) #9
smut
3 years, 7 months ago (2017-05-09 23:52:43 UTC) #10
Message was sent while issue was closed.
On 2017/05/09 23:36:05, davidben wrote:
> On 2017/05/09 23:31:25, smut wrote:
> > On 2017/05/09 23:29:48, smut wrote:
> > > On 2017/05/08 17:11:10, commit-bot: I haz the power wrote:
> > > > Committed patchset #1 (id:1) as
> > > >
> > >
> >
>
https://chromium.googlesource.com/chromium/src/+/f42a25f36d9ae587b3b8f2c584c4...
> > > 
> > > Lgtm. I didn't expect the BoringSSL tests to be missing from
> > gn_isolate_map.pyl
> > > since they run on other platforms as well, and gn_isolate_map.pyl is
> platform
> > > agnostic.
> > 
> > Oh, I see, the CL to land it on other platforms and add it to
> gn_isolate_map.pyl
> > hasn't been committed yet.
> 
> Yeah, the CQ's been exploding at that other one. Sorry about that. I didn't
> realize the two systems were related and figured if the try jobs didn't care,
> they could land in either order.

The ios-simulator try job passed because it actually skipped running the
analyzer (because ios-simulator.json was modified, it was going to compile
everything and run all tests).

Powered by Google App Engine
This is Rietveld 408576698