Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 2862843002: headless: Avoid copies for string parameters in DevTools bindings (Closed)

Created:
3 years, 7 months ago by Sami
Modified:
3 years, 7 months ago
Reviewers:
altimin
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

headless: Avoid copies for string parameters in DevTools bindings String parameters were being passed by value instead of by const reference by mistake. BUG=718242 Review-Url: https://codereview.chromium.org/2862843002 Cr-Commit-Position: refs/heads/master@{#469350} Committed: https://chromium.googlesource.com/chromium/src/+/1d15faaea01846f698bbd4082c582eb180a2a49e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M headless/lib/browser/devtools_api/client_api_generator.py View 4 chunks +5 lines, -3 lines 0 comments Download
M headless/lib/browser/devtools_api/client_api_generator_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Sami
3 years, 7 months ago (2017-05-04 11:13:35 UTC) #3
altimin
lgtm!
3 years, 7 months ago (2017-05-04 15:20:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2862843002/1
3 years, 7 months ago (2017-05-04 15:21:15 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 16:11:51 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1d15faaea01846f698bbd4082c58...

Powered by Google App Engine
This is Rietveld 408576698