headless/lib/browser/devtools_api/client_api_generator_unittest.py - Issue 2862843002: headless: Avoid copies for string parameters in DevTools bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: headless/lib/browser/devtools_api/client_api_generator_unittest.py

Issue 2862843002: headless: Avoid copies for string parameters in DevTools bindings (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: headless/lib/browser/devtools_api/client_api_generator_unittest.py

diff --git a/headless/lib/browser/devtools_api/client_api_generator_unittest.py b/headless/lib/browser/devtools_api/client_api_generator_unittest.py

index af1f44b900ed1ea18fbd8dca828b56b9dc00672d..aed56599d24337d6e0cd393dbff209528d503663 100755

--- a/headless/lib/browser/devtools_api/client_api_generator_unittest.py

+++ b/headless/lib/browser/devtools_api/client_api_generator_unittest.py

@@ -147,6 +147,7 @@ class ClientApiGeneratorTest(unittest.TestCase):

type = json_api['domains'][0]['types'][0]

resolved = client_api_generator.ResolveType(type)

self.assertEqual('std::string', resolved['raw_type'])

+ self.assertEqual('const std::string&', resolved['pass_type'])

def test_ObjectType(self):

json_api = {

« no previous file with comments | « headless/lib/browser/devtools_api/client_api_generator.py ('k') | no next file » | no next file with comments »